Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Exception Is Thrown for Invalid Index Name #2

Open
gordonbanderson opened this issue May 21, 2020 · 0 comments
Open

No Exception Is Thrown for Invalid Index Name #2

gordonbanderson opened this issue May 21, 2020 · 0 comments

Comments

@gordonbanderson
Copy link
Owner

Detailed description

This should throw an exception if the index name does not exist. Currently it simply returns an empty array

$this->indexes = new Indexes();
$this->indexes->getFacetFields('INVALID_INDEX_NAME');

Context

An invalid index name should trigger an exception when accessing properties. A blank array is a silent fail.

Possible implementation

Not obligatory, but suggest an idea for implementing addition or change.

Your environment

Testing using Docker and php-cli container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant