Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print total results banner at the end of execution #155

Closed
alexluix opened this issue Sep 27, 2019 · 0 comments · Fixed by #160
Closed

Print total results banner at the end of execution #155

alexluix opened this issue Sep 27, 2019 · 0 comments · Fixed by #160
Labels
good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed new_feature New features
Milestone

Comments

@alexluix
Copy link
Collaborator

alexluix commented Sep 27, 2019

As a user, I would like to see the final result of my execution indicating whether the execution was successful or not. Additionally, it would be useful to see total execution time for all executed commands.

In case of failed execution – I would like to see the phase that failed and exit code just in case.

Acceptance Criteria

  1. introduce status banner at the end of the last executed phase – this banner appears always at the end – in case of successful execution or at the end of the failed phase
  2. Example of a successful banner – width of the lines must be 72 characters:
------------------------------------------------------------------------
SUCCESS - Total time: 8s
------------------------------------------------------------------------
  1. Example of a failed banner:
Execution failed: phase 'a' - exit code: 127
------------------------------------------------------------------------
FAILURE - Total time:  1m 53s
------------------------------------------------------------------------

Notice that the line with Execution failed is a replacement of the current failure message. We are changing the format of the message to be more minimalistic.

  1. Success and Failure keywords should be coloured as the following:

    • SUCCESSCYAN
    • FAILURERED
  2. Total time

    • In min & sec
    • example:
      • 9s
      • 28s
      • 1m 59s
      • 7m

See the attached screenshot as an example.
1build_success
1build_failure

@alexluix alexluix added enhancement New feature or request good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed new_feature New features and removed enhancement New feature or request labels Sep 27, 2019
@alexluix alexluix added this to the v1.4.0 milestone Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ help wanted Extra attention is needed new_feature New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant