use EXIT\_FAILURE for fatal error conditions (fixes issue #13 by polluks)

gooofy · gooofy · commit e637abc411e2 · 2021-12-30T12:03:45.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@ Improvements:
 Bug Fixes:
 
     * examples: tetris code cleanup, use custom fonts
+    * use EXIT\_FAILURE for fatal error conditions (fixes issue #13 by polluks)
 
 ## 0.8.1
 
diff --git a/src/compiler/aqb.c b/src/compiler/aqb.c
@@ -102,7 +102,7 @@ static void check_amigaos_env(void)
     if ( ((struct Library *)DOSBase)->lib_Version < 37)
     {
         U_request (NULL, NULL, "OK", "DOS library V%d is too old, need at least V37", ((struct Library *)DOSBase)->lib_Version);
-        exit(1);
+        exit(EXIT_FAILURE);
     }
 
     struct Process *aqbProc;
diff --git a/src/compiler/compiler.c b/src/compiler/compiler.c
@@ -101,7 +101,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
 	if (!sourcef)
 	{
 		LOG_printf (LOG_ERROR, "failed to read %s: %s\n\n", sourcefn, strerror(errno));
-		CO_exit(2);
+		CO_exit(EXIT_FAILURE);
 	}
 
 	frags = FE_sourceProgram(sourcef, sourcefn, /*is_main=*/!symfn, module_name);
@@ -110,7 +110,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
     if (EM_anyErrors)
     {
         LOG_printf (LOG_ERROR, "\n\nfrontend processing failed - exiting.\n");
-        CO_exit(3);
+        CO_exit(EXIT_FAILURE);
     }
 
     LOG_printf (OPT_get(OPTION_VERBOSE) ? LOG_INFO : LOG_DEBUG, "\n\nsemantics worked.\n");
@@ -129,7 +129,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
         else
         {
             LOG_printf (LOG_ERROR, "\n** ERROR: failed to write symbol file %s .\n", symfn);
-            CO_exit(4);
+            CO_exit(EXIT_FAILURE);
         }
     }
 
@@ -164,7 +164,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
         if (!RA_regAlloc(frame, body) || EM_anyErrors)
         {
             LOG_printf (LOG_ERROR, "\n\nregister allocation failed - exiting.\n");
-            CO_exit(5);
+            CO_exit(EXIT_FAILURE);
         }
 
         CG_procEntryExitAS(frag);
@@ -185,7 +185,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
         if (!out)
         {
             LOG_printf (LOG_ERROR, "\n\nfailed to open asm file %s for writing.\n", asm_gas_fn);
-            CO_exit(6);
+            CO_exit(EXIT_FAILURE);
         }
         CG_writeASMFile (out, frags, AS_dialect_gas);
         fclose(out);
@@ -197,7 +197,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
         if (!out)
         {
             LOG_printf (LOG_ERROR, "\n\nfailed to open asm file %s for writing.\n", asm_asmpro_fn);
-            CO_exit(7);
+            CO_exit(EXIT_FAILURE);
         }
         CG_writeASMFile (out, frags, AS_dialect_ASMPro);
         fclose(out);
@@ -209,7 +209,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
         if (!out)
         {
             LOG_printf (LOG_ERROR, "\n\nfailed to open asm file %s for writing.\n", asm_vasm_fn);
-            CO_exit(8);
+            CO_exit(EXIT_FAILURE);
         }
         CG_writeASMFile (out, frags, AS_dialect_vasm);
         fclose(out);
@@ -245,21 +245,21 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
                 U_memstat();
 
                 if (!AS_assembleCode (obj, body, expt, frame))
-                    CO_exit(9);
+                    CO_exit(EXIT_FAILURE);
 
                 break;
             }
             case CG_stringFrag:
                 AS_assembleDataAlign2 (obj);
                 if (!AS_assembleString (obj, frag->u.stringg.label, frag->u.stringg.str, frag->u.stringg.msize))
-                    CO_exit(10);
+                    CO_exit(EXIT_FAILURE);
                 break;
             case CG_dataFrag:
                 if (!frag->u.data.size)
                     break;
                 AS_assembleDataAlign2 (obj);
                 if (!AS_assembleDataLabel (obj, frag->u.data.label, frag->u.data.expt, frag->u.data.ty))
-                    CO_exit(11);
+                    CO_exit(EXIT_FAILURE);
                 if (frag->u.data.init)
                 {
                     for (CG_dataFragNode n=frag->u.data.init; n; n=n->next)
@@ -268,7 +268,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
                         {
                             case CG_labelNode:
                                 if (!AS_assembleDataLabel (obj, n->u.label, /*expt=*/FALSE, /*ty=*/NULL))
-                                    CO_exit(12);
+                                    CO_exit(EXIT_FAILURE);
                                 break;
                             case CG_constNode:
                             {
@@ -331,14 +331,14 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
     if (EM_anyErrors)
     {
         LOG_printf (LOG_ERROR, "\n\nassembler failed - exiting.\n");
-        CO_exit(13);
+        CO_exit(EXIT_FAILURE);
     }
 
     if (objfn)
         LI_segmentWriteObjectFile (obj, objfn);
 
     if (!binfn)
-        CO_exit(0);
+        CO_exit(EXIT_FAILURE);
 
     /*
      * machine code generation (link phase)
@@ -352,12 +352,12 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
     if (!fObj)
     {
         LOG_printf (LOG_ERROR, "*** ERROR: failed to open startup.o\n\n");
-        CO_exit(14);
+        CO_exit(EXIT_FAILURE);
     }
     if (!LI_segmentListReadObjectFile (UP_link, sl, "startup.o", fObj))
     {
         fclose(fObj);
-        CO_exit(15);
+        CO_exit(EXIT_FAILURE);
     }
     fclose(fObj);
 
@@ -375,20 +375,20 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,
         if (!fObj)
         {
             LOG_printf (LOG_ERROR, "*** ERROR: failed to open %s\n\n", mod_fn);
-            CO_exit(16);
+            CO_exit(EXIT_FAILURE);
         }
         if (!LI_segmentListReadObjectFile (UP_link, sl, S_name(n->m->name), fObj))
         {
             fclose(fObj);
-            CO_exit(17);
+            CO_exit(EXIT_FAILURE);
         }
         fclose(fObj);
     }
 
     if (!LI_link (UP_link, sl))
     {
         LOG_printf (LOG_ERROR, "*** ERROR: failed to link.\n\n");
-        CO_exit(18);
+        CO_exit(EXIT_FAILURE);
     }
 
     LI_segmentListWriteLoadFile (sl, binfn);
diff --git a/src/compiler/dis68k.c b/src/compiler/dis68k.c
@@ -1033,7 +1033,7 @@ void DEBUG_disasm(IDE_instance ed, unsigned long int start, unsigned long int en
 					} break;
 
 					default : printf("opnum out of range in switch (=%i)\n", opnum);
-						exit(1);
+						exit(EXIT_FAILURE);
 				}
 			}
 			if (decoded) opnum = 88;
diff --git a/src/compiler/env.c b/src/compiler/env.c
@@ -303,7 +303,7 @@ static void env_fail (string msg)
         modf = NULL;
     }
 
-    exit(126);
+    exit(EXIT_FAILURE);
 }
 
 static void fwrite_double(FILE *f, double d)
diff --git a/src/compiler/ide.c b/src/compiler/ide.c
@@ -1476,7 +1476,7 @@ static bool _ide_save (IDE_instance ed, bool save_as)
     if (!sourcef)
     {
         fprintf(stderr, "failed to write %s: %s\n\n", ed->sourcefn, strerror(errno));
-        exit(2);
+        exit(EXIT_FAILURE);
     }
 
     static char *indent_str = "    ";
diff --git a/src/compiler/link.c b/src/compiler/link.c
@@ -62,7 +62,7 @@ static void link_fail (string msg)
         g_fObjFile = NULL;
     }
 
-    CO_exit(127);
+    CO_exit(EXIT_FAILURE);
 }
 
 #if LOG_LEVEL == LOG_DEBUG
@@ -1265,7 +1265,7 @@ void LI_segmentWriteObjectFile (AS_object obj, string objfn)
     if (!g_fObjFile)
     {
         LOG_printf (LOG_ERROR, "*** ERROR: failed to open %s for writing.\n\n", objfn);
-        exit(128);
+        CO_exit(EXIT_FAILURE);
     }
     write_hunk_unit (objfn, g_fObjFile);
 
@@ -1299,7 +1299,7 @@ void LI_segmentListWriteLoadFile (LI_segmentList sl, string loadfn)
     if (!g_fLoadFile)
     {
         LOG_printf (LOG_ERROR, "*** ERROR: failed to open %s for writing.\n\n", loadfn);
-        exit(128);
+        CO_exit(EXIT_FAILURE);
     }
     write_hunk_header (sl, g_fLoadFile);
 
diff --git a/src/compiler/options.c b/src/compiler/options.c
@@ -105,7 +105,7 @@ void OPT_init(void)
     if (snprintf (g_pref_fn, PATH_MAX, "%s/prefs.ini", aqb_home)<0)
     {
         fprintf (stderr, "prefs.ini path too long\n");
-        exit(42);
+        exit(EXIT_FAILURE);
     }
 #endif
 
diff --git a/src/compiler/ui_linux.c b/src/compiler/ui_linux.c
@@ -286,7 +286,7 @@ static uint16_t UI_getch (void)
     char c, seq[5];
     while ((nread = read(STDIN_FILENO,&c,1)) == 0);
     if (nread == -1)
-        exit(1);
+        exit(EXIT_FAILURE);
 
     while(1)
     {
diff --git a/src/compiler/util.c b/src/compiler/util.c
@@ -96,7 +96,7 @@ static void *checked_malloc (size_t len)
     if (!p)
     {
         LOG_printf(LOG_ERROR, "\nran out of memory!\n");
-        exit(1);
+        exit(EXIT_FAILURE);
     }
     // fprintf(stderr, "checked_malloc len=%zu -> p=%p\n", len, p);
     return p;
diff --git a/src/tools/reactiontest/ratest.c b/src/tools/reactiontest/ratest.c
@@ -105,15 +105,15 @@ int main(void)
         cleanexit("failed to open intuition.library\n");
     DPRINTF ("intuition.library opened\n");
 
-    if (! (WindowBase = OpenLibrary((STRPTR)"window.class", 47)) )
+    if (! (WindowBase = OpenLibrary((STRPTR)"window.class", 37)) )
         cleanexit("failed to open window.class\n");
     DPRINTF ("window.class opened\n");
 
-    if (! (LayoutBase = OpenLibrary((STRPTR)"gadgets/layout.gadget", 47)) )
+    if (! (LayoutBase = OpenLibrary((STRPTR)"gadgets/layout.gadget", 37)) )
         cleanexit("failed to open gadgets/layout.gadget\n");
     DPRINTF ("gadgets/layout.gadget opened\n");
 
-    if (! (ButtonBase = OpenLibrary((STRPTR)"gadgets/button.gadget", 47)) )
+    if (! (ButtonBase = OpenLibrary((STRPTR)"gadgets/button.gadget", 0)) )
         cleanexit("failed to open gadgets/button.gadget\n");
     DPRINTF ("gadgets/button.gadget opened\n");
 

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ static void check_amigaos_env(void)`
`102`	`102`	`if ( ((struct Library *)DOSBase)->lib_Version < 37)`
`103`	`103`	`{`
`104`	`104`	`U_request (NULL, NULL, "OK", "DOS library V%d is too old, need at least V37", ((struct Library *)DOSBase)->lib_Version);`
`105`		`- exit(1);`
	`105`	`+ exit(EXIT_FAILURE);`
`106`	`106`	`}`
`107`	`107`
`108`	`108`	`struct Process *aqbProc;`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`101`	`101`	`if (!sourcef)`
`102`	`102`	`{`
`103`	`103`	`LOG_printf (LOG_ERROR, "failed to read %s: %s\n\n", sourcefn, strerror(errno));`
`104`		`- CO_exit(2);`
	`104`	`+ CO_exit(EXIT_FAILURE);`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`frags = FE_sourceProgram(sourcef, sourcefn, /is_main=/!symfn, module_name);`
`@@ -110,7 +110,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`110`	`110`	`if (EM_anyErrors)`
`111`	`111`	`{`
`112`	`112`	`LOG_printf (LOG_ERROR, "\n\nfrontend processing failed - exiting.\n");`
`113`		`- CO_exit(3);`
	`113`	`+ CO_exit(EXIT_FAILURE);`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`LOG_printf (OPT_get(OPTION_VERBOSE) ? LOG_INFO : LOG_DEBUG, "\n\nsemantics worked.\n");`
`@@ -129,7 +129,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`129`	`129`	`else`
`130`	`130`	`{`
`131`	`131`	`LOG_printf (LOG_ERROR, "\n** ERROR: failed to write symbol file %s .\n", symfn);`
`132`		`- CO_exit(4);`
	`132`	`+ CO_exit(EXIT_FAILURE);`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`
`@@ -164,7 +164,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`164`	`164`	`if (!RA_regAlloc(frame, body) \|\| EM_anyErrors)`
`165`	`165`	`{`
`166`	`166`	`LOG_printf (LOG_ERROR, "\n\nregister allocation failed - exiting.\n");`
`167`		`- CO_exit(5);`
	`167`	`+ CO_exit(EXIT_FAILURE);`
`168`	`168`	`}`
`169`	`169`
`170`	`170`	`CG_procEntryExitAS(frag);`
`@@ -185,7 +185,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`185`	`185`	`if (!out)`
`186`	`186`	`{`
`187`	`187`	`LOG_printf (LOG_ERROR, "\n\nfailed to open asm file %s for writing.\n", asm_gas_fn);`
`188`		`- CO_exit(6);`
	`188`	`+ CO_exit(EXIT_FAILURE);`
`189`	`189`	`}`
`190`	`190`	`CG_writeASMFile (out, frags, AS_dialect_gas);`
`191`	`191`	`fclose(out);`
`@@ -197,7 +197,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`197`	`197`	`if (!out)`
`198`	`198`	`{`
`199`	`199`	`LOG_printf (LOG_ERROR, "\n\nfailed to open asm file %s for writing.\n", asm_asmpro_fn);`
`200`		`- CO_exit(7);`
	`200`	`+ CO_exit(EXIT_FAILURE);`
`201`	`201`	`}`
`202`	`202`	`CG_writeASMFile (out, frags, AS_dialect_ASMPro);`
`203`	`203`	`fclose(out);`
`@@ -209,7 +209,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`209`	`209`	`if (!out)`
`210`	`210`	`{`
`211`	`211`	`LOG_printf (LOG_ERROR, "\n\nfailed to open asm file %s for writing.\n", asm_vasm_fn);`
`212`		`- CO_exit(8);`
	`212`	`+ CO_exit(EXIT_FAILURE);`
`213`	`213`	`}`
`214`	`214`	`CG_writeASMFile (out, frags, AS_dialect_vasm);`
`215`	`215`	`fclose(out);`
`@@ -245,21 +245,21 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`245`	`245`	`U_memstat();`
`246`	`246`
`247`	`247`	`if (!AS_assembleCode (obj, body, expt, frame))`
`248`		`- CO_exit(9);`
	`248`	`+ CO_exit(EXIT_FAILURE);`
`249`	`249`
`250`	`250`	`break;`
`251`	`251`	`}`
`252`	`252`	`case CG_stringFrag:`
`253`	`253`	`AS_assembleDataAlign2 (obj);`
`254`	`254`	`if (!AS_assembleString (obj, frag->u.stringg.label, frag->u.stringg.str, frag->u.stringg.msize))`
`255`		`- CO_exit(10);`
	`255`	`+ CO_exit(EXIT_FAILURE);`
`256`	`256`	`break;`
`257`	`257`	`case CG_dataFrag:`
`258`	`258`	`if (!frag->u.data.size)`
`259`	`259`	`break;`
`260`	`260`	`AS_assembleDataAlign2 (obj);`
`261`	`261`	`if (!AS_assembleDataLabel (obj, frag->u.data.label, frag->u.data.expt, frag->u.data.ty))`
`262`		`- CO_exit(11);`
	`262`	`+ CO_exit(EXIT_FAILURE);`
`263`	`263`	`if (frag->u.data.init)`
`264`	`264`	`{`
`265`	`265`	`for (CG_dataFragNode n=frag->u.data.init; n; n=n->next)`
`@@ -268,7 +268,7 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`268`	`268`	`{`
`269`	`269`	`case CG_labelNode:`
`270`	`270`	`if (!AS_assembleDataLabel (obj, n->u.label, /expt=/FALSE, /ty=/NULL))`
`271`		`- CO_exit(12);`
	`271`	`+ CO_exit(EXIT_FAILURE);`
`272`	`272`	`break;`
`273`	`273`	`case CG_constNode:`
`274`	`274`	`{`
`@@ -331,14 +331,14 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`331`	`331`	`if (EM_anyErrors)`
`332`	`332`	`{`
`333`	`333`	`LOG_printf (LOG_ERROR, "\n\nassembler failed - exiting.\n");`
`334`		`- CO_exit(13);`
	`334`	`+ CO_exit(EXIT_FAILURE);`
`335`	`335`	`}`
`336`	`336`
`337`	`337`	`if (objfn)`
`338`	`338`	`LI_segmentWriteObjectFile (obj, objfn);`
`339`	`339`
`340`	`340`	`if (!binfn)`
`341`		`- CO_exit(0);`
	`341`	`+ CO_exit(EXIT_FAILURE);`
`342`	`342`
`343`	`343`	`/*`
`344`	`344`	`* machine code generation (link phase)`
`@@ -352,12 +352,12 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`352`	`352`	`if (!fObj)`
`353`	`353`	`{`
`354`	`354`	`LOG_printf (LOG_ERROR, "*** ERROR: failed to open startup.o\n\n");`
`355`		`- CO_exit(14);`
	`355`	`+ CO_exit(EXIT_FAILURE);`
`356`	`356`	`}`
`357`	`357`	`if (!LI_segmentListReadObjectFile (UP_link, sl, "startup.o", fObj))`
`358`	`358`	`{`
`359`	`359`	`fclose(fObj);`
`360`		`- CO_exit(15);`
	`360`	`+ CO_exit(EXIT_FAILURE);`
`361`	`361`	`}`
`362`	`362`	`fclose(fObj);`
`363`	`363`
`@@ -375,20 +375,20 @@ int CO_compile(string sourcefn, string module_name, string symfn, string objfn,`
`375`	`375`	`if (!fObj)`
`376`	`376`	`{`
`377`	`377`	`LOG_printf (LOG_ERROR, "*** ERROR: failed to open %s\n\n", mod_fn);`
`378`		`- CO_exit(16);`
	`378`	`+ CO_exit(EXIT_FAILURE);`
`379`	`379`	`}`
`380`	`380`	`if (!LI_segmentListReadObjectFile (UP_link, sl, S_name(n->m->name), fObj))`
`381`	`381`	`{`
`382`	`382`	`fclose(fObj);`
`383`		`- CO_exit(17);`
	`383`	`+ CO_exit(EXIT_FAILURE);`
`384`	`384`	`}`
`385`	`385`	`fclose(fObj);`
`386`	`386`	`}`
`387`	`387`
`388`	`388`	`if (!LI_link (UP_link, sl))`
`389`	`389`	`{`
`390`	`390`	`LOG_printf (LOG_ERROR, "*** ERROR: failed to link.\n\n");`
`391`		`- CO_exit(18);`
	`391`	`+ CO_exit(EXIT_FAILURE);`
`392`	`392`	`}`
`393`	`393`
`394`	`394`	`LI_segmentListWriteLoadFile (sl, binfn);`
Original file line number	Diff line number	Diff line change
`@@ -1033,7 +1033,7 @@ void DEBUG_disasm(IDE_instance ed, unsigned long int start, unsigned long int en`
`1033`	`1033`	`} break;`
`1034`	`1034`
`1035`	`1035`	`default : printf("opnum out of range in switch (=%i)\n", opnum);`
`1036`		`- exit(1);`
	`1036`	`+ exit(EXIT_FAILURE);`
`1037`	`1037`	`}`
`1038`	`1038`	`}`
`1039`	`1039`	`if (decoded) opnum = 88;`
Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ static void env_fail (string msg)`
`303`	`303`	`modf = NULL;`
`304`	`304`	`}`
`305`	`305`
`306`		`- exit(126);`
	`306`	`+ exit(EXIT_FAILURE);`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`static void fwrite_double(FILE *f, double d)`
Original file line number	Diff line number	Diff line change
`@@ -1476,7 +1476,7 @@ static bool _ide_save (IDE_instance ed, bool save_as)`
`1476`	`1476`	`if (!sourcef)`
`1477`	`1477`	`{`
`1478`	`1478`	`fprintf(stderr, "failed to write %s: %s\n\n", ed->sourcefn, strerror(errno));`
`1479`		`- exit(2);`
	`1479`	`+ exit(EXIT_FAILURE);`
`1480`	`1480`	`}`
`1481`	`1481`
`1482`	`1482`	`static char *indent_str = " ";`
Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ static void link_fail (string msg)`
`62`	`62`	`g_fObjFile = NULL;`
`63`	`63`	`}`
`64`	`64`
`65`		`- CO_exit(127);`
	`65`	`+ CO_exit(EXIT_FAILURE);`
`66`	`66`	`}`
`67`	`67`
`68`	`68`	`#if LOG_LEVEL == LOG_DEBUG`
`@@ -1265,7 +1265,7 @@ void LI_segmentWriteObjectFile (AS_object obj, string objfn)`
`1265`	`1265`	`if (!g_fObjFile)`
`1266`	`1266`	`{`
`1267`	`1267`	`LOG_printf (LOG_ERROR, "*** ERROR: failed to open %s for writing.\n\n", objfn);`
`1268`		`- exit(128);`
	`1268`	`+ CO_exit(EXIT_FAILURE);`
`1269`	`1269`	`}`
`1270`	`1270`	`write_hunk_unit (objfn, g_fObjFile);`
`1271`	`1271`
`@@ -1299,7 +1299,7 @@ void LI_segmentListWriteLoadFile (LI_segmentList sl, string loadfn)`
`1299`	`1299`	`if (!g_fLoadFile)`
`1300`	`1300`	`{`
`1301`	`1301`	`LOG_printf (LOG_ERROR, "*** ERROR: failed to open %s for writing.\n\n", loadfn);`
`1302`		`- exit(128);`
	`1302`	`+ CO_exit(EXIT_FAILURE);`
`1303`	`1303`	`}`
`1304`	`1304`	`write_hunk_header (sl, g_fLoadFile);`
`1305`	`1305`
Original file line number	Diff line number	Diff line change
`@@ -105,7 +105,7 @@ void OPT_init(void)`
`105`	`105`	`if (snprintf (g_pref_fn, PATH_MAX, "%s/prefs.ini", aqb_home)<0)`
`106`	`106`	`{`
`107`	`107`	`fprintf (stderr, "prefs.ini path too long\n");`
`108`		`- exit(42);`
	`108`	`+ exit(EXIT_FAILURE);`
`109`	`109`	`}`
`110`	`110`	`#endif`
`111`	`111`
Original file line number	Diff line number	Diff line change
`@@ -286,7 +286,7 @@ static uint16_t UI_getch (void)`
`286`	`286`	`char c, seq[5];`
`287`	`287`	`while ((nread = read(STDIN_FILENO,&c,1)) == 0);`
`288`	`288`	`if (nread == -1)`
`289`		`- exit(1);`
	`289`	`+ exit(EXIT_FAILURE);`
`290`	`290`
`291`	`291`	`while(1)`
`292`	`292`	`{`
Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ static void *checked_malloc (size_t len)`
`96`	`96`	`if (!p)`
`97`	`97`	`{`
`98`	`98`	`LOG_printf(LOG_ERROR, "\nran out of memory!\n");`
`99`		`- exit(1);`
	`99`	`+ exit(EXIT_FAILURE);`
`100`	`100`	`}`
`101`	`101`	`// fprintf(stderr, "checked_malloc len=%zu -> p=%p\n", len, p);`
`102`	`102`	`return p;`