Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI testing should catch compile errors in the example code #942

Open
roberthbailey opened this issue Jul 23, 2019 · 4 comments
Open

CI testing should catch compile errors in the example code #942

roberthbailey opened this issue Jul 23, 2019 · 4 comments
Labels
awaiting-maintainer Block issues from being stale/obsolete/closed kind/feature New features for Agones

Comments

@roberthbailey
Copy link
Member

One way to do this would be to have CI actually run e2e tests that execute the example code (as we do for the simple-udp server). But at minimum we should make sure that the code compiles.

I've recently run across a couple of examples of this:

  1. In Updates to the C++ SDK along with the simple example that exercises it. #934 I pushed a change with a typo (book instead of bool), but the build on that hash succeeded. Running make build locally caught the error immediately.

  2. I recently tried to grab the rust-simple example from the 0.11.0 release tag to deploy it on a 0.11.0 cluster to see if it used to work (while trying to debug Rust SDK does not wait for connection to be ready #938). Unfortunately, the example code didn't build at the release tag.

@roberthbailey roberthbailey added the kind/feature New features for Agones label Jul 23, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented Aug 28, 2019

I prepared a PR with building 5 projects from examples directory, but build now took 30 minutes. As it is hard to calculate hash of all the files in examples folders and understand what was changed from last build, we can call this test randomly for example one out of five pushes, using commit-id for instance. Another option is to remove this new step from cloudbuild or somehow use Prow to make this kind of build testing like nightly builds or by request.

@roberthbailey
Copy link
Member Author

I like the idea of doing this less frequently (since the examples don't change often) to not slow down all PRs.

@github-actions
Copy link

github-actions bot commented May 1, 2023

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label May 1, 2023
@markmandel markmandel added awaiting-maintainer Block issues from being stale/obsolete/closed and removed stale Pending closure unless there is a strong objection. labels May 1, 2023
@markmandel
Copy link
Collaborator

Added awaiting-maintainer as we should do something here at some point around this.

Maybe it should be conditional on if example code changed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Block issues from being stale/obsolete/closed kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

3 participants