CI testing should catch compile errors in the example code #942
Labels
awaiting-maintainer
Block issues from being stale/obsolete/closed
kind/feature
New features for Agones
One way to do this would be to have CI actually run e2e tests that execute the example code (as we do for the simple-udp server). But at minimum we should make sure that the code compiles.
I've recently run across a couple of examples of this:
In Updates to the C++ SDK along with the simple example that exercises it. #934 I pushed a change with a typo (
book
instead ofbool
), but the build on that hash succeeded. Runningmake build
locally caught the error immediately.I recently tried to grab the rust-simple example from the 0.11.0 release tag to deploy it on a 0.11.0 cluster to see if it used to work (while trying to debug Rust SDK does not wait for connection to be ready #938). Unfortunately, the example code didn't build at the release tag.
The text was updated successfully, but these errors were encountered: