-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdks/cpp needs unit tests #905
Comments
Yes please! We definitely need someone with C++ experience to write this 👍 |
'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions ' |
We should probably do this at some point. |
'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions ' |
Adding |
Heey @markmandel, would be good idea to add required tests, |
@zedGGs please go for it! Consider yourself assigned. Let us know if you have any questions here about the framework in place for SDKs, or in #development on Slack! |
@markmandel awesome stuff ! thanks, sure, |
Is your feature request related to a problem? Please describe.
The C++ code in sdks/cpp/ doesn't have any unit tests, so there's no way to verify that an of it works. This makes it difficult for anyone to contributed a change/fix to the code base, because there's no way to prove that the code works (before or) after the change.
Describe the solution you'd like
All the C++ files in sdks/cpp should have a
foo_test.cc
that corresponds tofoo.h
andfoo.cc
. The unit tests should be implemented using Google Test (https://github.com/google/googletest)Describe alternatives you've considered
None. There's no alternative to unit tests :-)
Additional context
There are other unit testing frameworks, but I believe Google Test is by far the most common for C++, and it's the one required for Google C++ code.
The text was updated successfully, but these errors were encountered: