Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure fleet autoscaler policy are namespaced #4098

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: ensure fleet autoscaler policy are namespaced #4098

wants to merge 3 commits into from

Conversation

lacroixthomas
Copy link
Collaborator

@lacroixthomas lacroixthomas commented Jan 24, 2025 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Ensure the fleet autoscaler policy are namespaced, to ensure it's not autoscaling on all namespaces (on fleet with same name but from different namespaces)

Which issue(s) this PR fixes:
Closes #3954

Special notes for your reviewer:
Did some manual tests following the steps described on the issue.

TODO:

  • Manual testing
  • Make sure the syncFleet() and the updateFleet() are also namespaced
  • Fixed current unit tests

@github-actions github-actions bot added kind/bug These are bugs. size/M labels Jan 24, 2025
@0xaravindh
Copy link
Member

/gcbrun

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ab15f2ec-5595-4ef5-8530-9eddaa897305

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the fix/fleet-autoscaler-not-namespaced branch from b5a6d1a to e9a8b98 Compare January 25, 2025 15:26
@markmandel
Copy link
Collaborator

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 8f343cff-43c4-4726-90fc-d566ff758fbf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4098/head:pr_4098 && git checkout pr_4098
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-e9a8b98

@lacroixthomas lacroixthomas marked this pull request as ready for review January 25, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/bug These are bugs. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FleetAutoscaler with Counter policy trying to scale Fleet to negative replicas count
4 participants
@lacroixthomas @0xaravindh @agones-bot @markmandel