CORS enabled on ping service

[Orgil]

Is your feature request related to a problem? Please describe.
checking ping from browser raises CORS issue.

Describe the solution you'd like
Enable CORS on ping service

[github-actions]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[markmandel]

🤔 on one hand, I'm wondering if we should do this... on the other, it feels like this should maybe be something a proxy or load balancer does? Not sure. 🤔

[github-actions]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[Orgil]

i my case, to overcome cors issue, i had to put a load balancer just for ping service over every regional cluster.

[markmandel]

i my case, to overcome cors issue, i had to put a load balancer just for ping service over every regional cluster.

How else where you exposing the ping service, if not without a LB?

[Orgil]

i forgot it what exactly happened, but i had to setup extra nginx on top of provider LB to solve cors. Maybe it was issue with cloud provider.

[markmandel]

Seems like a small fix to implement. Would love a PR.

[github-actions]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[0xaravindh]

It seems you're facing a CORS issue when checking the ping service. I didn’t encounter this issue myself.

Checkout this docs: Agones Ping Service HTTP Docs

karavindh@karavindh:~$ k describe service agones-ping-http-service --namespace=agones-system
Name:                     agones-ping-http-service
Namespace:                agones-system
Labels:                   app=agones
                          app.kubernetes.io/managed-by=Helm
                          chart=agones-1.48.0-dev
                          component=ping
                          heritage=Helm
                          release=agones
Annotations:              cloud.google.com/neg: {"ingress":true}
                          meta.helm.sh/release-name: agones
                          meta.helm.sh/release-namespace: agones-system
Selector:                 agones.dev/role=ping
Type:                     LoadBalancer
IP Family Policy:         SingleStack
IP Families:              IPv4
IP:                       34.118.239.126
IPs:                      34.118.239.126
LoadBalancer Ingress:     34.168.182.8 (VIP)
Port:                     http  80/TCP
TargetPort:               8080/TCP
NodePort:                 http  32741/TCP
Endpoints:                10.64.11.244:8080,10.64.6.64:8080
Session Affinity:         None
External Traffic Policy:  Cluster
Internal Traffic Policy:  Cluster
Events:
  Type    Reason                Age    From                Message
  ----    ------                ----   ----                -------
  Normal  EnsuringLoadBalancer  5m22s  service-controller  Ensuring load balancer
  Normal  EnsuredLoadBalancer   4m35s  service-controller  Ensured load balancer

karavindh@karavindh:~$ curl http://34.168.182.8:80; echo
ok
karavindh@karavindh:~$ 

@Orgil Could you please provide more details about the error you're facing?

[Orgil]

@0xaravindh as i remember, issue was related with browser, i called ping service from the browser. Browser requires SSL, so i had to setup load balancer as reverse proxy for terminating ssl. Issue rise if you put ping service behind reverse proxy, i guess.