Add OpenAPI x-kubernetes-patch keys for patching CRDs

[clrxbl]

Is your feature request related to a problem? Please describe.
I am using Kustomize to patch Agones Fleets. If I attempt to do this right now without a custom OpenAPI schema, it will simply replace what I'm attempting to patch instead of merging.

Describe the solution you'd like
Add x-kubernetes-patch keys to allow merging e.g. containers, initContainers and more.

Describe alternatives you've considered
I can get this working locally by exporting the OpenAPI schema and adding the keys myself.

Additional context
N/A

[vytskalt]

I've been looking into this and looks like the keys are specifically being removed:

agones/build/scripts/k8s-export-openapi/main.go

Lines 221 to 228 in 9e4400b

	keysToRemove := []string{
	"x-kubernetes-patch-strategy",
	"x-kubernetes-patch-merge-key",
	"x-kubernetes-list-type",
	"x-kubernetes-group-version-kind",
	"x-kubernetes-list-map-keys",
	"x-kubernetes-unions",
	}

Why is this the case?

[markmandel]

I'm going back through history (since this was done a while ago), but as far as I can tell, those properties are not supported on CRDs, so we strip them off sub-resources, such as PodTemplateSpec.

Happy to be proven wrong however!

[github-actions]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[markmandel]

Just checking in to see if there is more we can do here, or if my comment above about non-support on CRDs makes this a non-starter?

[clrxbl]

Just checking in to see if there is more we can do here, or if my comment above about non-support on CRDs makes this a non-starter?

I've been using patch merge keys for the past year for the past year or so without any issues on GameServer CRDs with Kustomize. I just had to end up exporting CRDs, manually modifying it to add the keys and passing it along to Kustomize to make it work.

[markmandel]

Sounds like it's worth a review!

Happy to also accept PRs with the changes to our tools and accompanying exports.

[github-actions]

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

[markmandel]

Moving to awaiting-maintainer since I do want to see this tackled at some point.