Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS labels are not supported in the Terraform provider, wrong Controller placement #1383

Closed
aLekSer opened this issue Mar 3, 2020 · 1 comment · Fixed by #1420
Closed
Assignees
Labels
area/operations Installation, updating, metrics etc kind/bug These are bugs.
Milestone

Comments

@aLekSer
Copy link
Collaborator

aLekSer commented Mar 3, 2020

Agones Controller pod get scheduled to the wrong node pool.

Due to a know bug in terraform provider, we can only assign taints to the Node pool (azurerm_kubernetes_cluster_node_pool resource)

hashicorp/terraform-provider-azurerm#4968
hashicorp/terraform-provider-azurerm#5531

This can be generalised to AKS Portal, which seems to not support labels as well.

What happened:
Pod got assigned to a wrong node pool, default, where GameServers resides.

What you expected to happen:
I have added a special output depends_on in order to wait for all azurerm_kubernetes_cluster_node_pool resource before running Helm Terraform module.
But taints does not help, cause we are using nodeAffinity with Labels:
https://kubernetes.io/docs/concepts/configuration/assign-pod-node/

    spec:
      affinity:
        nodeAffinity:
          preferredDuringSchedulingIgnoredDuringExecution:
          - preference:
              matchExpressions:
              - key: agones.dev/agones-system
                operator: Exists
            weight: 1

How to reproduce it (as minimally and precisely as possible):

Follow this guide
https://agones.dev/site/docs/installation/terraform/aks/

kubectl get pods --namespace agones-system
kubectl describe pod agones-controller-.. --namespace agones-system

Anything else we need to know?:
This ticket is blocked until AKS will update its provider.
By the way it seems there is now
AKS Node Pools NoLabels

Environment:

  • Agones version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others:
@aLekSer aLekSer added the kind/bug These are bugs. label Mar 3, 2020
@aLekSer aLekSer self-assigned this Mar 3, 2020
@aLekSer aLekSer added the area/operations Installation, updating, metrics etc label Mar 3, 2020
@aLekSer
Copy link
Collaborator Author

aLekSer commented Mar 18, 2020

Now that hashicorp/terraform-provider-azurerm#4968 is resolved I can start fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operations Installation, updating, metrics etc kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants