Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inter-line height is not the same as it used to be. (2.002 vs 1.013) #9

Closed
fearthecowboy opened this issue Apr 25, 2017 · 11 comments
Closed

Comments

@fearthecowboy
Copy link

(apologies for not knowing the 'font-terminology'... )

I recently downloaded a new version of Inconsolata and it has some significant changes from the previous:

image

There is a ton of extra whitespace in there... it doesn't feel right anymore 😢

Is that what you intended?

@davelab6
Copy link
Member

davelab6 commented Apr 25, 2017 via email

@fearthecowboy
Copy link
Author

Windows 10 (the built-in font viewer),

after installing the new version of the font, my console windows seemed way out of whack, so I did some investigating.

@fearthecowboy
Copy link
Author

Hmm. I think VSCode (which is electron-based) isn't doing the same thing...

Weird: the console window (which I made translucent) is rendering different than the vscode editor (behind, and fainter)

You can see they start off around the same, but they eventually end up different:

image

@fearthecowboy
Copy link
Author

It feels like the console window is squishing the font when it renders

@fearthecowboy
Copy link
Author

Hey @bitcrazed is it possible that the font renderer for the console window is doing something weird here?

I'd think I shouldn't see differences in the same font between VSCode and the console.

@fearthecowboy
Copy link
Author

Both the Font Viewer and the console use GDI, which we may have run into a funny bug in the latest font.

@alexeiva
Copy link
Collaborator

Left: Inco 1 | Right: Inco 2
screen shot 2017-04-27 at 10 15 11 am

Regression test shows identical v-metrics
screen shot 2017-04-27 at 10 12 54 am

@alexeiva
Copy link
Collaborator

My guess is the renderer uses winAscent(1004) to calculate line-heights instead of typoAscender(859). winAscent is meant for preventing clipping in tall glyphs, while typoAscender should affect line-height.

@bitcrazed
Copy link

It's likely that GDI is calculating max height for a tall char because fixed width fonts are usually used in grid layouts (e.g. Console/terminal apps). Will check

@fearthecowboy
Copy link
Author

@bitcrazed any progress on this?

@davelab6
Copy link
Member

I'm going to close this as I assume the metrics are staying as they are now. Please re-open or file a new issue if this is still a problem for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants