-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inter-line height is not the same as it used to be. (2.002 vs 1.013) #9
Comments
Where (what programs/OS) are you seeing that?
|
Windows 10 (the built-in font viewer), after installing the new version of the font, my console windows seemed way out of whack, so I did some investigating. |
It feels like the console window is squishing the font when it renders |
Hey @bitcrazed is it possible that the font renderer for the console window is doing something weird here? I'd think I shouldn't see differences in the same font between VSCode and the console. |
Both the Font Viewer and the console use GDI, which we may have run into a funny bug in the latest font. |
My guess is the renderer uses winAscent(1004) to calculate line-heights instead of typoAscender(859). winAscent is meant for preventing clipping in tall glyphs, while typoAscender should affect line-height. |
It's likely that GDI is calculating max height for a tall char because fixed width fonts are usually used in grid layouts (e.g. Console/terminal apps). Will check |
@bitcrazed any progress on this? |
I'm going to close this as I assume the metrics are staying as they are now. Please re-open or file a new issue if this is still a problem for you :) |
(apologies for not knowing the 'font-terminology'... )
I recently downloaded a new version of Inconsolata and it has some significant changes from the previous:
There is a ton of extra whitespace in there... it doesn't feel right anymore 😢
Is that what you intended?
The text was updated successfully, but these errors were encountered: