Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Commit

Permalink
exchange Platform.flush for deprecated dirtyCheck
Browse files Browse the repository at this point in the history
  • Loading branch information
sorvell committed Sep 3, 2013
1 parent 05a3a3e commit 5f01386
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion elements/animation/g-animation-group.html
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
this.doOnChildren(function(c) {
c.completeApply();
});
window.dirtyCheck();
Platform.flush();
this.super(arguments);
},
onAnimationChange: function(inEvent, inSender) {
Expand Down
2 changes: 1 addition & 1 deletion elements/animation/g-animation.html
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
play: function() {
// TODO: need to dirty check to make sure all side effects are
// applied before playing the animation.
window.dirtyCheck();
Platform.flush();
this.completeApply();
//this.animation && console.log('play', this.animation);
if (this.animation) {
Expand Down
6 changes: 3 additions & 3 deletions elements/g-panels.html
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@
},
canSelect: function(inIndex) {
var canSelect = true;
// TODO(sorvell): dirtyCheck before we sent the canSelect event since
// TODO(sorvell): Platform.flush(); before we sent the canSelect event since
// it's likely that the decision needs to rely on binding state.
// consider doing this in g-component.send.
Platform.flush();
Expand Down Expand Up @@ -326,8 +326,8 @@
} else if (e.keyCode == LEFT_ARROW_KEY) {
this.previous();
}
// TODO(sorvell): dirtyCheck so we know syncronously if index changed.
dirtyCheck();
// TODO(sorvell): Platform.flush() so we know syncronously if index changed.
Platform.flush();
if (this.index != oldIndex) {
e.cancelBubble = true;
this.focus();
Expand Down
4 changes: 2 additions & 2 deletions elements/g-togglebutton.html
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,11 @@
this.$.toggle.classList.remove('dragging');
this.value = Math.abs(this.x) < this.w / 2;
// make valueChanged calls immediately
dirtyCheck();
Platform.flush();
},
flick: function(e) {
this.value = e.xVelocity > 0;
dirtyCheck();
Platform.flush();
}
});
</script>
Expand Down

0 comments on commit 5f01386

Please sign in to comment.