Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Decide on whether to move to core elements? #3

Closed
addyosmani opened this issue Jun 16, 2014 · 4 comments
Closed

Decide on whether to move to core elements? #3

addyosmani opened this issue Jun 16, 2014 · 4 comments

Comments

@addyosmani
Copy link

Will <polymer-signals> be getting moved to core? It seems like something that gets used enough that it might be worth officially supporting beyond labs.

We currently use it in some of our Google Web Component elements.

@sjmiles
Copy link
Contributor

sjmiles commented Jun 16, 2014

Polymer wants you to avoid having lateral communication and have all communication mediated by a controller. IOW, have an explicit container that knows both targets and manages their communication. As an architecture, it can feel like extra work at first, but ultimately provides vastly more robust designs.

For this reason I have been dragging my feet wrt to porting polymer-signals. Once people find this device, they tend to use it all over the place and lose sight of the critical information above.

This is not a good reason, so I will endeavor to port this right away. But please help me establish best practices by avoiding the use of *-signals as much as possible.

@robdodson
Copy link

SGTM, I wholeheartedly agree on the explicit container principle.

@addyosmani
Copy link
Author

SGTM 2. Thanks for taking the time to port the element over, @sjmiles. I fully appreciate the desire to avoid excessive use of this pattern so we'll do our best to ensure it's use is limited to only where it makes absolute sense.

@sjmiles
Copy link
Contributor

sjmiles commented Aug 18, 2014

core-signals exists now, but whether it's implemented properly is another question. I ported the original code which deserves a fresh look.

@sjmiles sjmiles closed this as completed Aug 18, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants