Correctly forward preventDefault for mouse and pointer events

Fixes #18 Fixes #20
googlearchive · Jul 11, 2014 · e0fbe4c · e0fbe4c
1 parent 5490290
commit e0fbe4c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/samples/simple/index.html b/samples/simple/index.html
@@ -12,7 +12,7 @@
 <html>
   <head>
     <meta charset="UTF-8">
-    <meta name="viewport" content="width=device-width user-scalable=no">
+    <meta name="viewport" content="width=device-width, user-scalable=no">
     <title>polymer-gestures testing ground</title>
     <style>
       * {
@@ -70,7 +70,9 @@
       <div id="enterleave">
       </div>
     </div>
-    <div id="wrapper"><div id="output"></div></div>
+    <div id="wrapper">
+      <div id="output"></div>
+    </div>
     <script>
       var events = [
         // base events
@@ -97,14 +99,9 @@
       events.forEach(function(en) {
         capture.addEventListener(en, function(inEvent) {
           appendOutput(inEvent.type + ' [' + inEvent.pointerId + ']');
+          inEvent.preventDefault();
         });
       });
-      enterleave.addEventListener('pointerenter', function(e) {
-        appendOutput('enterleave entered');
-      });
-      enterleave.addEventListener('pointerleave', function(e) {
-        appendOutput('enterleave left');
-      });
     </script>
   </body>
 </html>
diff --git a/src/dispatcher.js b/src/dispatcher.js
@@ -259,7 +259,9 @@
         }
       }
       // keep the semantics of preventDefault
-      eventCopy.preventDefault = inEvent.preventDefault;
+      eventCopy.preventDefault = function() {
+        inEvent.preventDefault();
+      };
       return eventCopy;
     },
     /**