Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Commit 1ca8375

Browse files
committed
Turn on property observation earlier. This change enhances compatibility with previous behavior for the time being. It will probably be changed back soon.
1 parent bad4a4e commit 1ca8375

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/instance/base.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
this.shadowRoots = {};
4747
// install property observers
4848
this.createPropertyObserver();
49+
// TODO (sorvell): temporarily open observer when created
50+
this.openPropertyObserver();
4951
// install boilerplate attributes
5052
this.copyInstanceAttributes();
5153
// process input attributes
@@ -54,6 +56,10 @@
5456
this.addHostListeners();
5557
},
5658
makeElementReady: function() {
59+
if (this._readied) {
60+
return;
61+
}
62+
this._readied = true;
5763
// TODO(sorvell): We could create an entry point here
5864
// for the user to compute property values.
5965
// process declarative resources
@@ -64,8 +70,9 @@
6470
this.removeAttribute('unresolved');
6571
// user entry point
6672
this.ready();
73+
// TODO (sorvell): temporarily open observer when created
6774
// turn on property observation and take any initial changes
68-
this.openPropertyObserver();
75+
//this.openPropertyObserver();
6976
},
7077
attachedCallback: function() {
7178
this.cancelUnbindAll();

0 commit comments

Comments
 (0)