Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Core-transitionend should only fire when button actually gets clicked #36

Open
AndreasGalster opened this issue Apr 1, 2015 · 1 comment

Comments

@AndreasGalster
Copy link

Sometimes you hover over a button and you press and hold to click it but then you decide "Nope, I'm not going to click yet, I still need to do something on this page". The problem with core-transitionend is that you cannot do this. Even if you don't actually click the button, the core-transitionend still fires, which will cause the event to happen. Although from a user's point of view they haven't really clicked the button.

@beauwest
Copy link

It makes sense to have some sort of rippleCompleted event. It sounds like the current way to handle this would be to use

<paper-ripple id="ripple" style="pointer-events: none;"></paper-ripple>

and then provide your own custom ripple start, and ripple end handling. However, pointer-events has no affect in my testing.

Another possible way to fix it currently would be to have your own up/down handling, then on up, poll for this.$.ripple.animating to turn false.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants