Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Ripple remains visible #16

Closed
IntranetFactory opened this issue Sep 9, 2014 · 9 comments
Closed

Ripple remains visible #16

IntranetFactory opened this issue Sep 9, 2014 · 9 comments

Comments

@IntranetFactory
Copy link

Just tested in current version e.g. demo.html

Press and hold mouse in first box until ripple fully shows, release mouse button without moving mouse.

Result: the ripple remains visible.
Expected: ripple is removed when mouse is released

If the button is released before the circle is complete it disappears, same if the mouse is moved.

e.g.
2014-09-09_1533b

@morethanreal
Copy link
Contributor

Which browser and browser version do you see this issue in? Are you testing this against current versions of the dependencies? I cannot reproduce this in Chrome 38, Canary, FF and Safari with everything updated to master.

@morethanreal morethanreal self-assigned this Sep 9, 2014
@IntranetFactory
Copy link
Author

I'm testing with everything master. Fails in Chrome 37, works in IE11.

@frankiefu
Copy link
Contributor

It works fine for me in Chrome 37.0.2062.120. I tested with latest paper-ripple via bower install Polymer/paper-ripple#master.

@IntranetFactory
Copy link
Author

I'm running Version 37.0.2062.120 m on Win 8.1, just made a bower update, cleared browser cache and still same behaviour

http://screencast.com/t/qZKfumhGMG

But maybe it's just a problem with my Chrome (as my IE11 and Firefox work)

@morethanreal
Copy link
Contributor

Sounds like maybe a gestures issue on windows? @azakus can you take a look?

@morethanreal morethanreal assigned dfreedm and unassigned morethanreal Sep 9, 2014
@dfreedm
Copy link
Contributor

dfreedm commented Sep 22, 2014

Sorry, I can't reproduce this with Windows 8 and Chrome 37. @IntranetFactory, are you still seeing this with 0.4.1?

@IntranetFactory
Copy link
Author

Still happens - just made bower update to ensure I've the latest version. Chrome Version 37.0.2062.120 m, Win 8.1

Just recorded: http://screencast.com/t/gRQnL7bpN

@dfreedm
Copy link
Contributor

dfreedm commented Sep 22, 2014

I'm pretty sure I figured it out. The wave could get into a state where it was maximum size on the up and 0 time has passed between the event and the requestAnimationFrame loop. This would abort the render loop too early. Now we check if the wave should be growing or shrinking.

@dheera
Copy link

dheera commented Oct 7, 2015

This still occurs, even with 1.1.4, and even on Polymer's own official website.

2015-10-07 05 47 12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants