-
Notifications
You must be signed in to change notification settings - Fork 15
Ripple remains visible #16
Comments
Which browser and browser version do you see this issue in? Are you testing this against current versions of the dependencies? I cannot reproduce this in Chrome 38, Canary, FF and Safari with everything updated to master. |
I'm testing with everything master. Fails in Chrome 37, works in IE11. |
It works fine for me in Chrome 37.0.2062.120. I tested with latest paper-ripple via |
I'm running Version 37.0.2062.120 m on Win 8.1, just made a bower update, cleared browser cache and still same behaviour http://screencast.com/t/qZKfumhGMG But maybe it's just a problem with my Chrome (as my IE11 and Firefox work) |
Sounds like maybe a gestures issue on windows? @azakus can you take a look? |
Sorry, I can't reproduce this with Windows 8 and Chrome 37. @IntranetFactory, are you still seeing this with |
Still happens - just made bower update to ensure I've the latest version. Chrome Version 37.0.2062.120 m, Win 8.1 Just recorded: http://screencast.com/t/gRQnL7bpN |
I'm pretty sure I figured it out. The wave could get into a state where it was maximum size on the up and 0 time has passed between the event and the requestAnimationFrame loop. This would abort the render loop too early. Now we check if the wave should be growing or shrinking. |
Just tested in current version e.g. demo.html
Press and hold mouse in first box until ripple fully shows, release mouse button without moving mouse.
Result: the ripple remains visible.
Expected: ripple is removed when mouse is released
If the button is released before the circle is complete it disappears, same if the mouse is moved.
e.g.
The text was updated successfully, but these errors were encountered: