Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Should be easier to size an icon via css #8

Closed
sorvell opened this issue Jul 12, 2014 · 4 comments
Closed

Should be easier to size an icon via css #8

sorvell opened this issue Jul 12, 2014 · 4 comments
Assignees

Comments

@sorvell
Copy link
Contributor

sorvell commented Jul 12, 2014

core-icon sizes via an attribute. This makes it highly inconvenient to style via css and forces any elements that compose core-icon to have to forward the size attribute.

It would be better if core-icon simple was sized via css.

@sorvell sorvell self-assigned this Jul 12, 2014
@cletusw
Copy link

cletusw commented Jul 15, 2014

Awesome, thanks!

@opticode
Copy link

opticode commented Aug 6, 2014

Topeka will have to be updated because of this change, as all its icons are now really small (24x24 px).

@cletusw
Copy link

cletusw commented Aug 6, 2014

They look good to me. Maybe you need to run bower cache clean before bower update inside the topeka folder?

@opticode
Copy link

opticode commented Aug 6, 2014

Thanks, that did the trick! The wrapper DIV around core-icon still had a class of category-bg-wrapper instead of category-bg for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants