Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

core-theme-aware is extended but not imported #1

Closed
jmesserly opened this issue Jun 18, 2014 · 2 comments
Closed

core-theme-aware is extended but not imported #1

jmesserly opened this issue Jun 18, 2014 · 2 comments

Comments

@jmesserly
Copy link
Contributor

https://github.com/Polymer/core-icon-button/blob/master/core-icon-button.html#L32

it's listed in extends= but not included. Using bower, I didn't see it included, even via transitive dependency ... not sure what's going on. It's still extended in a lot of core-elements, just not imported in html or depended on in bower.json ...

@jmesserly
Copy link
Contributor Author

oh, nevermind "lots of elements" ... most of those grep hits were from https://github.com/Polymer/core-home-page-dev/tree/master/components. Is core-theme-aware obsolete?

@sjmiles
Copy link
Contributor

sjmiles commented Jun 18, 2014

Yes, core-theme-aware is deprecated.

We are still working on our system for managing such changes, sorry for the
confusion.

On Wed, Jun 18, 2014 at 3:24 PM, John Messerly [email protected]
wrote:

oh, nevermind "lots of elements" ... most of those grep hits were from
https://github.com/Polymer/core-home-page-dev/tree/master/components. Is
core-theme-aware obsolete?


Reply to this email directly or view it on GitHub
#1 (comment)
.

sjmiles pushed a commit that referenced this issue Jun 18, 2014
remove core-theme-aware from extends, fixes #1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants