Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

Prevent adding 'content-type' header if one already exists #20

Merged
merged 2 commits into from
Aug 22, 2014

Conversation

elliottsj
Copy link
Contributor

Fixes #19

  • Added a hasContentType boolean to determine whether a 'Content-Type' header already exists. (Should this be a helper function instead?)
  • Renamed args.headers['content-type'] to args.headers['Content-Type'] because header names conventionally have the first letter of each word capitalized. Sometimes lowercase can cause issues.

@ebidel
Copy link
Contributor

ebidel commented Aug 18, 2014

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

@addyosmani
Copy link
Contributor

Thanks for signing the CLA!

@sjmiles sjmiles assigned dfreedm and unassigned sjmiles Aug 21, 2014
@sjmiles
Copy link
Contributor

sjmiles commented Aug 21, 2014

Reassigning to module owner of record.

@dfreedm
Copy link
Contributor

dfreedm commented Aug 22, 2014

LGTM, thanks!

dfreedm added a commit that referenced this pull request Aug 22, 2014
Prevent adding 'content-type' header if one already exists
@dfreedm dfreedm merged commit edb0b70 into googlearchive:master Aug 22, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'content-type' header is set even if 'Content-Type' is specified in headers
5 participants