core-ajax can pass body data directly to xhr for further processing; core-xhr makes decisions about the structuring request data based on method (see #3)

Author: Scott J. Miles

core-ajax.html

@@ -277,10 +277,8 @@
        */
       go: function() {
         var args = this.xhrArgs || {};
-        // TODO(sjmiles): we may want to default to POST if body is set
-        if (this.bodyMethods[this.method.toUpperCase()]) {
-          args.body = this.body || args.body;
-        }
+        // TODO(sjmiles): we may want XHR to default to POST if body is set
+        args.body = this.body || args.body;
         args.params = this.params || args.params;
         if (args.params && typeof(args.params) == 'string') {
           args.params = JSON.parse(args.params);
@@ -301,12 +299,6 @@
         args.url = this.url;
         args.method = this.method;
         return args.url && this.xhr.request(args);
-      },
-    
-      bodyMethods: {
-        POST: 1,
-        PUT: 1,
-        DELETE: 1
       }
 
     });

core-xhr.html

@@ -38,32 +38,6 @@
 
     Polymer('core-xhr', {
 
-      makeReadyStateHandler: function(xhr, callback) {
-        xhr.onreadystatechange = function() {
-          if (xhr.readyState == 4) {
-            callback && callback.call(null, xhr.response, xhr);
-          }
-        };
-      },
-
-      setRequestHeaders: function(xhr, headers) {
-        if (headers) {
-          for (var name in headers) {
-            xhr.setRequestHeader(name, headers[name]);
-          }
-        }
-      },
-
-      toQueryString: function(params) {
-        var r = [];
-        for (var n in params) {
-          var v = params[n];
-          n = encodeURIComponent(n);
-          r.push(v == null ? n : (n + '=' + encodeURIComponent(v)));
-        }
-        return r.join('&');
-      },
-
       /**
        * Sends a HTTP request to the server and returns the XHR object.
        *
@@ -85,10 +59,13 @@
         var url = options.url;
         var method = options.method || 'GET';
         var async = !options.sync;
+        //
         var params = this.toQueryString(options.params);
         if (params && method == 'GET') {
           url += (url.indexOf('?') > 0 ? '&' : '?') + params;
         }
+        var xhrParams = this.isBodyMethod(method) ? (options.body || params) : null;
+        //
         xhr.open(method, url, async);
         if (options.responseType) {
           xhr.responseType = options.responseType;
@@ -98,11 +75,47 @@
         }
         this.makeReadyStateHandler(xhr, options.callback);
         this.setRequestHeaders(xhr, options.headers);
-        xhr.send(method == 'POST' ? (options.body || params) : null);
+        xhr.send(xhrParams);
         if (!async) {
           xhr.onreadystatechange(xhr);
         }
         return xhr;
+      },
+    
+      toQueryString: function(params) {
+        var r = [];
+        for (var n in params) {
+          var v = params[n];
+          n = encodeURIComponent(n);
+          r.push(v == null ? n : (n + '=' + encodeURIComponent(v)));
+        }
+        return r.join('&');
+      },
+
+      isBodyMethod: function(method) {
+        return this.bodyMethods[(method || '').toUpperCase()];
+      },
+      
+      bodyMethods: {
+        POST: 1,
+        PUT: 1,
+        DELETE: 1
+      },
+
+      makeReadyStateHandler: function(xhr, callback) {
+        xhr.onreadystatechange = function() {
+          if (xhr.readyState == 4) {
+            callback && callback.call(null, xhr.response, xhr);
+          }
+        };
+      },
+
+      setRequestHeaders: function(xhr, headers) {
+        if (headers) {
+          for (var name in headers) {
+            xhr.setRequestHeader(name, headers[name]);
+          }
+        }
       }
 
     });