This repository has been archived by the owner on Mar 13, 2018. It is now read-only.
Make set chainable
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.set` should return self, according to the spec https://people.mozilla.org/~jorendorff/es6-draft.html#sec-weakmap.prototype.set
|
Thanks for your PR! Before this can be merged, please sign the CLA. See the CONTRIBUTING guide. |
|
Done. |
|
Thanks for signing the CLA! |
|
LGTM Can you add a test too? |
|
Modified test to check chaining. |
|
@addyosmani This is fine. The tests here are very bare bones anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.setshould return self, according to the spec https://people.mozilla.org/~jorendorff/es6-draft.html#sec-weakmap.prototype.set