Inverted hasChildNodes() logic to ensure that the existance of a firs…

…tChild means there are childNodes. Added test to verify hasChildNodes() change with formatting per guidelines.
googlearchive · Oct 9, 2013 · 895860f · 895860f
1 parent 0f72cea
commit 895860f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/wrappers/Node.js b/src/wrappers/Node.js
@@ -373,7 +373,7 @@
     },
 
     hasChildNodes: function() {
-      return this.firstChild === null;
+      return this.firstChild !== null;
     },
 
     /** @type {Node} */

diff --git a/test/js/Node.js b/test/js/Node.js
@@ -186,4 +186,16 @@ suite('Node', function() {
 
     expectStructure(host2, {});
   });
+
+  test('hasChildNodes without a shadow root', function() {
+    var div = document.createElement('div');
+
+    assert.isFalse(div.hasChildNodes(), 'should be false with no children');
+
+    div.innerHTML = '<span></span>';
+    assert.isTrue(div.hasChildNodes(), 'should be true with a single child');
+
+    div.innerHTML = '<span></span><ul></ul>';
+    assert.isTrue(div.hasChildNodes(), 'should be true with multiple children');
+  });
 });