From 785fe4cac983af9b322f2a5a43a5a7c5c614eb10 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Wed, 13 Aug 2025 16:33:12 -0400 Subject: [PATCH 1/4] chore: Update auto triage guidelines --- .github/workflows/gemini-issue-automated-triage.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gemini-issue-automated-triage.yml b/.github/workflows/gemini-issue-automated-triage.yml index 565f552ad0..72539c268e 100644 --- a/.github/workflows/gemini-issue-automated-triage.yml +++ b/.github/workflows/gemini-issue-automated-triage.yml @@ -92,7 +92,10 @@ jobs: variables: "${ISSUE_TITLE}" and "${ISSUE_BODY}". 3. Classify issues by their kind (bug, enhancement, documentation, cleanup, etc) and their priority (p0, p1, p2, p3). Set the - labels accoridng to the format `kind/*` and `priority/*` patterns. + labels accoridng to the format `type: *` and `priority: *` patterns. + If the priority is decided to be more urgent than p2 (e.g. p0 or p1), mark the issue + as p2 and leave a comment in the issue with the reason. The comment should ping + @blakeli0, @lqiu96, and @zhumin8 to notify them. 4. Apply the selected labels to this issue using: `gh issue edit "${ISSUE_NUMBER}" --add-label "label1,label2"` 5. If the "status/needs-triage" label is present, remove it using: @@ -100,6 +103,7 @@ jobs: ## Guidelines + - If there are already labels for `type: *` and `priority: *`, do not modify them - Only use labels that already exist in the repository - Do not add comments or modify the issue content - Triage only the current issue @@ -118,4 +122,4 @@ jobs: repo: '${{ github.repository }}'.split('/')[1], issue_number: '${{ github.event.issue.number }}', body: 'There is a problem with the Gemini CLI issue triaging. Please check the [action logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}) for details.' - }) \ No newline at end of file + }) From 4c4b11b878b44190c0b4b2e1ebbdb69e44cef702 Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Wed, 13 Aug 2025 16:40:30 -0400 Subject: [PATCH 2/4] chore: Add more detailed instructions for triaging issues --- .../gemini-issue-automated-triage.yml | 8 +++---- .../gemini-issue-scheduled-triage.yml | 22 +++++++++---------- 2 files changed, 13 insertions(+), 17 deletions(-) diff --git a/.github/workflows/gemini-issue-automated-triage.yml b/.github/workflows/gemini-issue-automated-triage.yml index 72539c268e..ba14257742 100644 --- a/.github/workflows/gemini-issue-automated-triage.yml +++ b/.github/workflows/gemini-issue-automated-triage.yml @@ -90,16 +90,14 @@ jobs: 1. Run: `gh label list` to get all available labels. 2. Review the issue title and body provided in the environment variables: "${ISSUE_TITLE}" and "${ISSUE_BODY}". - 3. Classify issues by their kind (bug, enhancement, documentation, + 3. Classify issues by their type (bug, enhancement, documentation, cleanup, etc) and their priority (p0, p1, p2, p3). Set the - labels accoridng to the format `type: *` and `priority: *` patterns. + labels according to the format `type: *` and `priority: *` patterns. If the priority is decided to be more urgent than p2 (e.g. p0 or p1), mark the issue - as p2 and leave a comment in the issue with the reason. The comment should ping + as p2 and add a comment in the issue with the reason. The comment should ping @blakeli0, @lqiu96, and @zhumin8 to notify them. 4. Apply the selected labels to this issue using: `gh issue edit "${ISSUE_NUMBER}" --add-label "label1,label2"` - 5. If the "status/needs-triage" label is present, remove it using: - `gh issue edit "${ISSUE_NUMBER}" --remove-label "status/needs-triage"` ## Guidelines diff --git a/.github/workflows/gemini-issue-scheduled-triage.yml b/.github/workflows/gemini-issue-scheduled-triage.yml index 8b05d01703..2677919f9f 100644 --- a/.github/workflows/gemini-issue-scheduled-triage.yml +++ b/.github/workflows/gemini-issue-scheduled-triage.yml @@ -41,10 +41,6 @@ jobs: NO_LABEL_ISSUES="$(gh issue list --repo "${GITHUB_REPOSITORY}" \ --search 'is:open is:issue no:label' --json number,title,body)" - echo '🏷️ Finding issues that need triage...' - NEED_TRIAGE_ISSUES="$(gh issue list --repo "${GITHUB_REPOSITORY}" \ - --search 'is:open is:issue label:"status/needs-triage"' --json number,title,body)" - echo '🔄 Merging and deduplicating issues...' ISSUES="$(echo "${NO_LABEL_ISSUES}" "${NEED_TRIAGE_ISSUES}" | jq -c -s 'add | unique_by(.number)')" @@ -98,17 +94,19 @@ jobs: 1. Run: `gh label list` 2. Check environment variable: "${ISSUES_TO_TRIAGE}" (JSON array of issues) - 3. For each issue, apply labels: - `gh issue edit "${ISSUE_NUMBER}" --add-label "label1,label2"`. - If available, set labels that follow the `kind/*`, `area/*`, - and `priority/*` patterns. - 4. For each issue, if the `status/needs-triage` label is present, - remove it using: - `gh issue edit "${ISSUE_NUMBER}" --remove-label "status/needs-triage"` + 3. Classify each issue by their type (bug, enhancement, documentation, + cleanup, etc) and their priority (p0, p1, p2, p3). Set the + labels according to the format `type: *` and `priority: *` patterns. + If the priority is decided to be more urgent than p2 (e.g. p0 or p1), mark the issue + as p2 and add a comment in the issue with the reason. The comment should ping + @blakeli0, @lqiu96, and @zhumin8 to notify them. + 4. Apply the selected labels to this issue using: + `gh issue edit "${ISSUE_NUMBER}" --add-label "label1,label2"` ## Guidelines + - If there are already labels for `type: *` and `priority: *`, do not modify them - Only use existing repository labels - - Do not add comments + - Do not add comments or modify the issue content - Triage each issue independently - Reference all shell variables as "${VAR}" (with quotes and braces) \ No newline at end of file From 07cf4330bf422810244bfc795e19435525753d9d Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Wed, 13 Aug 2025 16:58:41 -0400 Subject: [PATCH 3/4] chore: Fix PR comments --- .github/workflows/gemini-issue-automated-triage.yml | 4 ++-- .github/workflows/gemini-issue-scheduled-triage.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/gemini-issue-automated-triage.yml b/.github/workflows/gemini-issue-automated-triage.yml index ba14257742..6f6ae3ff43 100644 --- a/.github/workflows/gemini-issue-automated-triage.yml +++ b/.github/workflows/gemini-issue-automated-triage.yml @@ -101,9 +101,9 @@ jobs: ## Guidelines - - If there are already labels for `type: *` and `priority: *`, do not modify them + - If there are already labels for `type: *` and `priority: *` set on the issue, do not modify the labels - Only use labels that already exist in the repository - - Do not add comments or modify the issue content + - Do not modify the original issue content - Triage only the current issue - Assign all applicable labels based on the issue content - Reference all shell variables as "${VAR}" (with quotes and braces) diff --git a/.github/workflows/gemini-issue-scheduled-triage.yml b/.github/workflows/gemini-issue-scheduled-triage.yml index 2677919f9f..6c1a3ea40d 100644 --- a/.github/workflows/gemini-issue-scheduled-triage.yml +++ b/.github/workflows/gemini-issue-scheduled-triage.yml @@ -105,8 +105,8 @@ jobs: ## Guidelines - - If there are already labels for `type: *` and `priority: *`, do not modify them + - If there are already labels for `type: *` and `priority: *` set on the issue, do not modify the labels - Only use existing repository labels - - Do not add comments or modify the issue content + - Do not modify the original issue content - Triage each issue independently - Reference all shell variables as "${VAR}" (with quotes and braces) \ No newline at end of file From f9fe4c16e7ebf680836f02da743f87ca87ae37ee Mon Sep 17 00:00:00 2001 From: Lawrence Qiu Date: Wed, 13 Aug 2025 16:59:37 -0400 Subject: [PATCH 4/4] chore: Fix PR comments --- .github/workflows/gemini-issue-automated-triage.yml | 2 +- .github/workflows/gemini-issue-scheduled-triage.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/gemini-issue-automated-triage.yml b/.github/workflows/gemini-issue-automated-triage.yml index 6f6ae3ff43..b0b0beafc7 100644 --- a/.github/workflows/gemini-issue-automated-triage.yml +++ b/.github/workflows/gemini-issue-automated-triage.yml @@ -93,7 +93,7 @@ jobs: 3. Classify issues by their type (bug, enhancement, documentation, cleanup, etc) and their priority (p0, p1, p2, p3). Set the labels according to the format `type: *` and `priority: *` patterns. - If the priority is decided to be more urgent than p2 (e.g. p0 or p1), mark the issue + If the priority is determined to be more urgent than p2 (e.g. p0 or p1), mark the issue as p2 and add a comment in the issue with the reason. The comment should ping @blakeli0, @lqiu96, and @zhumin8 to notify them. 4. Apply the selected labels to this issue using: diff --git a/.github/workflows/gemini-issue-scheduled-triage.yml b/.github/workflows/gemini-issue-scheduled-triage.yml index 6c1a3ea40d..c16294eb13 100644 --- a/.github/workflows/gemini-issue-scheduled-triage.yml +++ b/.github/workflows/gemini-issue-scheduled-triage.yml @@ -97,7 +97,7 @@ jobs: 3. Classify each issue by their type (bug, enhancement, documentation, cleanup, etc) and their priority (p0, p1, p2, p3). Set the labels according to the format `type: *` and `priority: *` patterns. - If the priority is decided to be more urgent than p2 (e.g. p0 or p1), mark the issue + If the priority is determined to be more urgent than p2 (e.g. p0 or p1), mark the issue as p2 and add a comment in the issue with the reason. The comment should ping @blakeli0, @lqiu96, and @zhumin8 to notify them. 4. Apply the selected labels to this issue using: