chore: Enable Gemini CLI Github Actions #3880
Conversation
blakeli0
left a comment
blakeli0
left a comment
There was a problem hiding this comment.
Is it possible to try out this on a branch first?
|
@gemini-cli /review |
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
1 similar comment
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review Summary
This pull request introduces a set of GitHub Actions workflows to integrate the Gemini CLI for various tasks like pull request reviews and issue triage. The workflows are well-structured and make good use of GitHub Actions features.
🔍 General Feedback
- The use of
google-github-actions/run-gemini-cliis consistent across all workflows. - The prompts for the Gemini CLI are well-defined and provide good context for the AI.
- The workflows are triggered on appropriate events.
I have left one comment regarding a block of commented-out code that should be removed. Otherwise, the changes look good.
|
@gemini-cli /review |
|
Ah, it seems like the reason this is skipping is because I am |
Hmm, I am a member of |
|
@gemini-cli /review |
There was a problem hiding this comment.
📋 Review Summary
This pull request introduces a set of GitHub Actions workflows to integrate the Gemini CLI for various tasks like automated issue triage, PR reviews, and general interaction. The workflows are well-structured and seem to be generated from a template, following good practices.
🔍 General Feedback
- The workflows are comprehensive and cover a good range of use cases for the Gemini CLI.
- The use of a GitHub App for authentication is a good security practice.
- The prompts provided to the Gemini CLI are detailed and well-thought-out.
- I've suggested a minor improvement to use the
ghCLI consistently for posting comments, which aligns with the existing style in the workflows.
Overall, this is a great addition to the repository's automation capabilities.
|
@gemini-cli /review |
1 similar comment
|
@gemini-cli /review |
There was a problem hiding this comment.
📋 Review Summary
This PR introduces four new GitHub workflows to integrate the Gemini CLI for various automated tasks. The workflows are for general CLI interaction, automated and scheduled issue triage, and pull request reviews.
🔍 General Feedback
- The workflows are well-structured and make good use of GitHub Actions features like concurrency control and reusable steps.
- There are a few areas for improvement, mainly related to the correctness of action references and the simplification of conditional logic.
- Pinning actions to a specific commit hash is a good security practice.
- The
ifcondition for the PR review workflow was commented out, which would have caused it to run on every PR event. This has been flagged for correction.
|
@gemini-cli /review |
|
@gemini-cli /review |
|
@gemini-cli /review |
1 similar comment
|
@gemini-cli /review |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@gemini-cli /review |
|
@gemini-cli explain this PR |
There was a problem hiding this comment.
📋 Review Summary
This PR introduces two new GitHub workflows for interacting with the Gemini CLI. The workflows are well-structured, but there are a few areas that need improvement, primarily around security, stability, and consistency.
🔍 General Feedback
- Security: The
gemini-cli.ymlworkflow is missing a step to generate a GitHub token, which will cause it to fail. - Stability: The actions used in both workflows should be pinned to specific versions to avoid unexpected changes.
- Consistency: The versions of
actions/checkoutandactions/github-scriptshould be consistent with the recommended versions. - Clarity: The commit messages in
gemini-cli.ymlcould be more descriptive. - Correctness: The
ifcondition ingemini-pr-review.ymlis commented out, which will cause the workflow to run on every pull request and issue comment. This should be uncommented.
Overall, the changes are good, but addressing the feedback will make the workflows more robust and maintainable.
|
Oh... I'm trying to invoke this command via a comment from a branch. The docs say: |
product-auto-label
bot
added
size: xl
lqiu96
force-pushed
the
use-gemini-cli-gh-actions
branch
from
2c1dbc6 to
904c6f9
Compare
product-auto-label
bot
added
size: l
|
|
Following https://github.com/google-github-actions/run-gemini-cli Code is generated with `/setup-github`
2 participants
Following https://github.com/google-github-actions/run-gemini-cli
Code is generated with
/setup-github