Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internet request in unit tests #3347

Open
JoeWang1127 opened this issue Nov 7, 2024 · 0 comments
Open

Remove internet request in unit tests #3347

JoeWang1127 opened this issue Nov 7, 2024 · 0 comments
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

The unit tests in hermetic_build/release_note_generation/tests/generate_pr_description_unit_tests.py have real git clone and git checkout. However, it is not a best practice for unit tests to depend on internet request as it is slow and flaky.

We should mock these operations to make the unit tests quick and deterministic.
@JoeWang1127 JoeWang1127 changed the title Remove real git checkout in unit tests Remove internet request in unit tests Nov 7, 2024
@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. hermetic-build labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermetic-build priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoeWang1127