Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gax: investigate GoogleCredentialsProvider JWT with scopes with service account workflows #3127

Open
zhumin8 opened this issue Aug 20, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@zhumin8
Copy link
Contributor

zhumin8 commented Aug 20, 2024

In GoogleCredentialsProvider, getCredentials() has 2 JWT with scopes with service account workflows:

These 2 workflows looks suspicious to me, is there reasons why both are needed?

Separately, our guidance is to use ServiceAccountCredentials with SSJWT whenever possible. (see related issue). Thus if both are to keep, the first one can be updated to use ServiceAccountCredentials.

@zhumin8 zhumin8 changed the title gax: gax: investigate GoogleCredentialsProvider JWT with scopes with service account workflows Aug 20, 2024
@zhumin8 zhumin8 added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Aug 20, 2024
@ldetmer ldetmer added the type: question Request for information or clarification. Not an issue. label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

2 participants