From 84ed106ec044b24313492499fa17872caee1c386 Mon Sep 17 00:00:00 2001 From: summerji Date: Tue, 1 Dec 2020 00:04:03 -0800 Subject: [PATCH] modify body expr --- .../composer/MethodSampleCodeHelperComposer.java | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/main/java/com/google/api/generator/gapic/composer/MethodSampleCodeHelperComposer.java b/src/main/java/com/google/api/generator/gapic/composer/MethodSampleCodeHelperComposer.java index ec2e4e9c19..bd8d6278e3 100644 --- a/src/main/java/com/google/api/generator/gapic/composer/MethodSampleCodeHelperComposer.java +++ b/src/main/java/com/google/api/generator/gapic/composer/MethodSampleCodeHelperComposer.java @@ -26,7 +26,6 @@ import com.google.api.generator.gapic.model.MethodArgument; import com.google.api.generator.gapic.model.ResourceName; import com.google.api.generator.gapic.utils.JavaStyle; -import java.util.ArrayList; import java.util.List; import java.util.Map; import java.util.stream.Collectors; @@ -42,7 +41,7 @@ public static TryCatchStatement composeUnaryRpcMethodSampleCode( VariableExpr clientVarExpr = createVariableExpr(getClientName(clientType), clientType); // Assign each method arguments with its default value. Map methodArgVarExprMap = createMethodArgumentsVariableExprs(arguments); - List methodArgumentsAssignmentExpr = + List bodyExpr = assignMethodArgumentsWithDefaultValues(arguments, methodArgVarExprMap, resourceNames); List methodVarExprs = arguments.stream() @@ -52,28 +51,23 @@ public static TryCatchStatement composeUnaryRpcMethodSampleCode( // e.g. if return void, echoClient.echo(..); or, // e.g. if return other type, EchoResponse response = echoClient.echo(...); boolean returnsVoid = isProtoEmptyType(method.outputType()); - Expr responseExpr = null; if (returnsVoid) { - responseExpr = + bodyExpr.add( MethodInvocationExpr.builder() .setExprReferenceExpr(clientVarExpr) .setMethodName(JavaStyle.toLowerCamelCase(method.name())) .setArguments(methodVarExprs) .setReturnType(clientType) - .build(); + .build()); } else { - responseExpr = + bodyExpr.add( createAssignExprForVariableWithClientMethod( createVariableExpr(RESPONSE, method.outputType()), clientVarExpr, JavaStyle.toLowerCamelCase(method.name()), - methodVarExprs); + methodVarExprs)); } - List bodyExpr = new ArrayList<>(); - bodyExpr.addAll(methodArgumentsAssignmentExpr); - bodyExpr.add(responseExpr); - return TryCatchStatement.builder() .setTryResourceExpr(assignClientVariableWithCreateMethodExpr(clientVarExpr)) .setTryBody(