Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component-no-space not allowed in json schema #2471

Open
landlockedboat opened this issue Jan 27, 2025 · 0 comments
Open

component-no-space not allowed in json schema #2471

landlockedboat opened this issue Jan 27, 2025 · 0 comments
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@landlockedboat
Copy link

landlockedboat commented Jan 27, 2025

Environment details

  • OS: Ubuntu 22.04.5 LTS x86_64
  • Node.js version: v22.11.0
  • npm version: 10.9.0
  • release-please version: v16.15.0

Steps to reproduce

Code available at https://github.com/landlockedboat/release-please-test

The configuration we are using is as follows:

{
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json",
  "include-component-in-tag": true,
  "tag-separator": "@",
  "pull-request-title-pattern": "chore(${component}): release ${version}",
  "pull-request-header": ":rocket: New Release",
  "separate-pull-requests": true,
  "component-no-space" : true,
  "packages": {
    "api": {
      "release-type": "maven",
      "skip-snapshot": true,
      "package-name": "api"
    },
    "ui": {
      "release-type": "node"
    },
    "chart": {
      "release-type": "helm"
    }
  }
}

vscode warns us that Property component-no-space is not allowed.

We suspect the issue is because in the schema:

"properties": {
    "$schema": true,
    "packages": true,
    [...],
    "component-no-space": false
  }

component-no-space is set to false, which we suspect is making release-please mark it as invalid.

@landlockedboat landlockedboat added priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants