fix(bucket): Move blob fails when the new blob name contains characters that need to be url encoded

[rcleveng]

fix(bucket): url encode new_name parameter in move_blob()

The move_blob() method was not URL encoding the new_name parameter
before passing it to the API call, unlike how the blob encodes its own
path. This caused failures when moving blobs to paths with special
characters.

Added URL encoding for new_name to match the blob path encoding, as
both names must fit in the API URL format: "{blob_path}/moveTo/o/{new_name}"

Here's an example of what fails:

from google.cloud import storage
gcs = storage.Client()
bucket = gcs.bucket("")
blob = bucket.get_blob("test/blob.csv")
bucket.move_blob(
    blob, 
    new_name="test/blob2.csv"
)

Fixes #1523

[gemini-code-assist]

Summary of Changes

Hello @rcleveng, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the Google Cloud Storage client library's Bucket#move_blob() function. Previously, attempts to move blobs to a new name containing special characters that required URL encoding would result in an error. The implemented fix ensures that the new_name is properly URL-encoded before constructing the API request path, thereby preventing these failures and significantly improving the robustness and reliability of blob movement operations for a wider array of object names.

Highlights

• Bug Fix: Resolves an issue where Bucket#move_blob() failed when the target blob name contained characters that required URL encoding.
• URL Encoding: The new_name parameter in the move_blob method is now explicitly URL-encoded using the _quote utility before being used in the API request path.
• Test Coverage: A new unit test, test_move_blob_needs_url_encoding, has been added to verify the correct URL encoding behavior for blob move operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug in Bucket.move_blob() where the new blob name was not being URL-encoded, causing failures for names containing special characters like '/'. The fix involves using the existing _quote helper to encode the new_name before constructing the API request path. A new unit test, test_move_blob_needs_url_encoding, has been added to verify this fix and prevent future regressions. The changes are correct, well-tested, and I approve of them.

[rcleveng]

Hey @chandra-siri is there anything else I need to do here on this one?

[chandra-siri]

LGTM.

[chandra-siri]

Hey @chandra-siri is there anything else I need to do here on this one?

1. You need to update the branch and resolve conflicts, if any.
2. Add systems tests in tests/system/test_bucket.py (you can raise a separate PR , or we'll do it in couple of days)

Thanks for fixing this issue.

[chandra-siri]

@rcleveng I've reviewed it now. Thanks for your patience and apologies for the delay.

[chandra-siri]

Hi @rcleveng

No additional action required. I've merged this PR and raised PR for system tests as well. #1624