resolving comments

Author: shubham-up-47

google/cloud/storage/_media/requests/download.py

@@ -133,9 +133,9 @@ def _write_to_stream(self, response):
             # object to the decoder and return a _DoNothingHash here.
             local_checksum_object = _add_decoder(response.raw, checksum_object)
 
+            # This is useful for smaller files, or when the user wants to
+            # download the entire file in one go.
             if self.single_shot_download:
-                # This is useful for smaller files, or when the user wants to
-                # download the entire file in one go.
                 content = response.raw.read(decode_content=True)
                 self._stream.write(content)
                 self._bytes_downloaded += len(content)
@@ -356,9 +356,9 @@ def _write_to_stream(self, response):
             checksum_object = self._checksum_object
 
         with response:
+            # This is useful for smaller files, or when the user wants to
+            # download the entire file in one go.
             if self.single_shot_download:
-                # This is useful for smaller files, or when the user wants to
-                # download the entire file in one go.
                 content = response.raw.read()
                 self._stream.write(content)
                 self._bytes_downloaded += len(content)

google/cloud/storage/blob.py

@@ -1052,6 +1052,8 @@ def _do_download(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
         """
 
         extra_attributes = {
@@ -1233,6 +1235,8 @@ def download_to_file(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
 
         :raises: :class:`google.cloud.exceptions.NotFound`
         """
@@ -1387,6 +1391,8 @@ def download_to_filename(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
 
         :raises: :class:`google.cloud.exceptions.NotFound`
         """
@@ -1507,6 +1513,8 @@ def download_as_bytes(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
 
         :rtype: bytes
         :returns: The data stored in this blob.
@@ -1623,6 +1631,8 @@ def download_as_string(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
 
         :rtype: bytes
         :returns: The data stored in this blob.
@@ -1740,6 +1750,8 @@ def download_as_text(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
 
         :rtype: text
         :returns: The data stored in this blob, decoded to text.
@@ -4336,6 +4348,8 @@ def _prep_and_do_download(
         :type single_shot_download: bool
         :param single_shot_download:
             (Optional) If true, download the object in a single request.
+            Caution: Enabling this will increase the memory overload for your application.
+            Please enable this as per your user use case.
 
         :type command: str
         :param command:

tests/system/test_blob.py

@@ -1156,7 +1156,6 @@ def test_blob_download_as_bytes_single_shot_download(
 ):
     blob_name = f"download-single-shot-{uuid.uuid4().hex}"
     info = file_data["simple"]
-    payload = None
     with open(info["path"], "rb") as f:
         payload = f.read()