Skip to content

Commit 99d40cb

Browse files
committed
cleanup: Rename beforeNextRetry to before_next_retry.
Signed-off-by: Taylor Curran <[email protected]>
1 parent 0d8a7da commit 99d40cb

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

google/cloud/spanner_v1/_helpers.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ def _retry(
535535
retry_count=5,
536536
delay=2,
537537
allowed_exceptions=None,
538-
beforeNextRetry=None,
538+
before_next_retry=None,
539539
):
540540
"""
541541
Retry a function with a specified number of retries, delay between retries, and list of allowed exceptions.
@@ -552,8 +552,8 @@ def _retry(
552552
"""
553553
retries = 0
554554
while retries <= retry_count:
555-
if retries > 0 and beforeNextRetry:
556-
beforeNextRetry(retries, delay)
555+
if retries > 0 and before_next_retry:
556+
before_next_retry(retries, delay)
557557

558558
try:
559559
return func()

google/cloud/spanner_v1/transaction.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -199,17 +199,17 @@ def wrapped_method(*args, **kwargs):
199199
)
200200
return method(*args, **kwargs)
201201

202-
def beforeNextRetry(nthRetry, delayInSeconds):
202+
def before_next_retry(nth_retry, delay_in_seconds):
203203
add_span_event(
204204
span,
205205
"Transaction Begin Attempt Failed. Retrying",
206-
{"attempt": nthRetry, "sleep_seconds": delayInSeconds},
206+
{"attempt": nth_retry, "sleep_seconds": delay_in_seconds},
207207
)
208208

209209
response = _retry(
210210
wrapped_method,
211211
allowed_exceptions={InternalServerError: _check_rst_stream_error},
212-
beforeNextRetry=beforeNextRetry,
212+
before_next_retry=before_next_retry,
213213
)
214214
self._transaction_id = response.id
215215
return self._transaction_id
@@ -348,17 +348,17 @@ def wrapped_method(*args, **kwargs):
348348
)
349349
return method(*args, **kwargs)
350350

351-
def beforeNextRetry(nthRetry, delayInSeconds):
351+
def before_next_retry(nth_retry, delay_in_seconds):
352352
add_span_event(
353353
span,
354354
"Transaction Commit Attempt Failed. Retrying",
355-
{"attempt": nthRetry, "sleep_seconds": delayInSeconds},
355+
{"attempt": nth_retry, "sleep_seconds": delay_in_seconds},
356356
)
357357

358358
response = _retry(
359359
wrapped_method,
360360
allowed_exceptions={InternalServerError: _check_rst_stream_error},
361-
beforeNextRetry=beforeNextRetry,
361+
before_next_retry=before_next_retry,
362362
)
363363

364364
add_span_event(span, "Commit Done")

0 commit comments

Comments
 (0)