Skip to content

Commit 9f19b38

Browse files
authored
test: drop Python 3.6 tests (#811)
1 parent a983b28 commit 9f19b38

File tree

4 files changed

+73
-8
lines changed

4 files changed

+73
-8
lines changed

.github/workflows/integration-tests-against-emulator.yml renamed to .github/workflows/integration-tests-against-emulator-3.7.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,10 @@ on:
33
branches:
44
- main
55
pull_request:
6-
name: Run Django Spanner integration tests against emulator
6+
name: Run Django Spanner integration tests against emulator 3.7
77
jobs:
88
system-tests:
99
runs-on: ubuntu-latest
10-
strategy:
11-
matrix:
12-
python-version: [3.6, 3.7, 3.8, 3.9]
1310

1411
services:
1512
emulator:
@@ -21,14 +18,14 @@ jobs:
2118
steps:
2219
- name: Checkout code
2320
uses: actions/checkout@v3
24-
- name: Set up Python ${{ matrix.python-version }}
21+
- name: Set up Python 3.7
2522
uses: actions/setup-python@v4
2623
with:
27-
python-version: ${{ matrix.python-version }}
24+
python-version: 3.7
2825
- name: Install nox
2926
run: python -m pip install nox
3027
- name: Run nox
31-
run: nox
28+
run: nox -s unit-3.7
3229
env:
3330
SPANNER_EMULATOR_HOST: localhost:9010
3431
GOOGLE_CLOUD_PROJECT: emulator-test-project
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
on:
2+
push:
3+
branches:
4+
- main
5+
pull_request:
6+
name: Run Django Spanner integration tests against emulator 3.8
7+
jobs:
8+
system-tests:
9+
runs-on: ubuntu-latest
10+
11+
services:
12+
emulator:
13+
image: gcr.io/cloud-spanner-emulator/emulator:latest
14+
ports:
15+
- 9010:9010
16+
- 9020:9020
17+
18+
steps:
19+
- name: Checkout code
20+
uses: actions/checkout@v3
21+
- name: Set up Python 3.8
22+
uses: actions/setup-python@v4
23+
with:
24+
python-version: 3.8
25+
- name: Install nox
26+
run: python -m pip install nox
27+
with:
28+
python-version: 3.8
29+
- name: Run nox
30+
run: nox -s unit-3.8
31+
env:
32+
SPANNER_EMULATOR_HOST: localhost:9010
33+
GOOGLE_CLOUD_PROJECT: emulator-test-project
34+
GOOGLE_CLOUD_TESTS_CREATE_SPANNER_INSTANCE: true
Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
on:
2+
push:
3+
branches:
4+
- main
5+
pull_request:
6+
name: Run Django Spanner integration tests against emulator 3.9
7+
jobs:
8+
system-tests:
9+
runs-on: ubuntu-latest
10+
11+
services:
12+
emulator:
13+
image: gcr.io/cloud-spanner-emulator/emulator:latest
14+
ports:
15+
- 9010:9010
16+
- 9020:9020
17+
18+
steps:
19+
- name: Checkout code
20+
uses: actions/checkout@v3
21+
- name: Set up Python 3.9
22+
uses: actions/setup-python@v4
23+
with:
24+
python-version: 3.9
25+
- name: Install nox
26+
run: python -m pip install nox
27+
with:
28+
python-version: 3.9
29+
- name: Run nox
30+
run: nox -s unit-3.9
31+
env:
32+
SPANNER_EMULATOR_HOST: localhost:9010
33+
GOOGLE_CLOUD_PROJECT: emulator-test-project
34+
GOOGLE_CLOUD_TESTS_CREATE_SPANNER_INSTANCE: true

django_spanner/features.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,7 @@ class DatabaseFeatures(BaseDatabaseFeatures):
502502
# Check constraints are not supported by Spanner emulator.
503503
"constraints.tests.CheckConstraintTests.test_database_constraint", # noqa
504504
"constraints.tests.CheckConstraintTests.test_name", # noqa
505-
"admin_docs.test_views.AdminDocViewDefaultEngineOnly.test_template_detail_path_traversal",
505+
"admin_docs.test_views.AdminDocViewDefaultEngineOnly.test_template_detail_path_traversal", # noqa
506506
# Untyped parameters are not supported:
507507
# https://github.com/GoogleCloudPlatform/cloud-spanner-emulator#features-and-limitations
508508
"auth_tests.test_admin_multidb.MultiDatabaseTests.test_add_view", # noqa

0 commit comments

Comments
 (0)