Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export gapic autogenerated types in the __init__.py of google.cloud.logging_v2 #808

Open
gkevinzheng opened this issue Nov 2, 2023 · 0 comments
Assignees
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@gkevinzheng
Copy link
Contributor

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
PR #804 is a good short-term fix for the issue #582, but we should be considering more long-term fixes.

Describe the solution you'd like
Use the autogenerated __init__.py as a base, which already has the autogenerated types exported in it, then combine it with the handwritten __init__.py.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Might be related to this issue: googleapis/gapic-generator-python#1642

@gkevinzheng gkevinzheng self-assigned this Nov 2, 2023
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Nov 2, 2023
@gkevinzheng gkevinzheng added priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern. labels Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant