Skip to content

chore(tests): fix timezone test #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

chore(tests): fix timezone test #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions tests/unit/v1/test_aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,8 +430,12 @@ def test_aggregation_query_prep_stream_with_read_time():
assert kwargs == {"retry": None}


@pytest.mark.parametrize("timezone", [None, timezone.utc, timezone(timedelta(hours=5))])
def test_aggregation_query_get_stream_iterator_read_time_different_timezones(timezone):
@pytest.mark.parametrize(
"custom_timezone", [None, timezone.utc, timezone(timedelta(hours=5))]
)
def test_aggregation_query_get_stream_iterator_read_time_different_timezones(
custom_timezone,
):
client = make_client()
parent = client.collection("dee")
query = make_query(parent)
Expand All @@ -441,10 +445,8 @@ def test_aggregation_query_get_stream_iterator_read_time_different_timezones(tim
aggregation_query.sum("someref", alias="sumall")
aggregation_query.avg("anotherref", alias="avgall")

# 1800 seconds after epoch
read_time = datetime(1970, 1, 1, 0, 30)
if timezone is not None:
read_time = read_time.astimezone(timezone)
# 1800 seconds after epoch in user-specified timezone
read_time = datetime.fromtimestamp(1800, tz=custom_timezone)

# The internal firestore API needs to be initialized before it gets mocked.
client._firestore_api
Expand Down
Loading