From 92b503a4ec17f8fc8dabfc24b58ac58fe10eb57f Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Mon, 14 Feb 2022 17:34:42 +0000 Subject: [PATCH] fix: remove libcst as a required dependency (#389) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Remove libcst dependency libcst is only used for a one-off "fixup" script. It’s not necessary to always depend on it. It caused an issue on one project as old libcst versions don't ship macOS M1 wheels, and it took time to figure this out. (Also the instructions for using the fixup script were incorrect.) * Update UPGRADING.md Co-authored-by: Tim Swast --- UPGRADING.md | 7 ++++--- setup.py | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/UPGRADING.md b/UPGRADING.md index cab98087..ef35b962 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -132,11 +132,12 @@ wrapper around the auto-generated `read_rows()` method. python3 -m pip install google-cloud-bigquery-storage ``` -* The script `fixup_storage_v1_keywords.py` is shipped with the library. It expects -an input directory (with the code to convert) and an empty destination directory. +* The script `fixup_bigquery_storage_v1_keywords.py` is shipped with the library. It +requires `libcst` to be installed. It expects an input directory (with the code +to convert) and an empty destination directory. ```sh -$ scripts/fixup_storage_v1_keywords.py --input-directory .samples/ --output-directory samples/ +$ fixup_bigquery_storage_v1_keywords.py --input-directory .samples/ --output-directory samples/ ``` **Before:** diff --git a/setup.py b/setup.py index fe6f5f89..e56a2f0f 100644 --- a/setup.py +++ b/setup.py @@ -29,7 +29,6 @@ # https://github.com/googleapis/google-cloud-python/issues/10566 "google-api-core[grpc] >= 1.28.0, <3.0.0dev", "proto-plus >= 1.18.0", - "libcst >= 0.2.5", ] extras = { "pandas": ["pandas>=0.21.1"],