Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1150] Fix grouped label #1155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[1150] Fix grouped label #1155

wants to merge 1 commit into from

Conversation

snapiri
Copy link
Contributor

@snapiri snapiri commented Jan 19, 2025

If we have a labeled custom function that we are grouping by, and the function does not support the default dialect, we can not compile our query.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

Fixes #1150 🦕

@snapiri snapiri requested review from a team as code owners January 19, 2025 06:49
@snapiri snapiri requested a review from alvarowolfx January 19, 2025 06:49
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 19, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. label Jan 19, 2025
@snapiri
fix: fix grouped labels using custom functions
87696fb 
If we have a labeled custom function that we are grouping by, and the
function does not support the `default` dialect, we can not compile our
query.
@snapiri snapiri force-pushed the 1150-Fix_grouped_label branch from 670082f to 87696fb Compare January 19, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarowolfx alvarowolfx Awaiting requested review from alvarowolfx alvarowolfx is a code owner automatically assigned from googleapis/api-bigquery

At least 1 approving review is required to merge this pull request.

Assignees

@chelsea-lin chelsea-lin

Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compilation of a labeled custom FunctionElement fails when used in grouping
2 participants
@snapiri @chelsea-lin