Skip to content

Commit ff3273f

Browse files
authored
deps: require google-cloud-bigquery-storage to avoid performance warning (#414)
The wrapped DB-API uses google-cloud-bigquery-storage to download query results by default. It raises a warning and falls back to the REST API if google-cloud-bigquery-storage is not installed. The google-cloud-bigquery version 3.x library is tested in #401 and it does not include any breaking changes that should affect the SQLAlchemy connector. deps: allow google-cloud-bigquery version 3.x Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery-sqlalchemy/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
1 parent ca20d3d commit ff3273f

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

setup.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,9 @@ def readme():
8484
# Until this issue is closed
8585
# https://github.com/googleapis/google-cloud-python/issues/10566
8686
"google-auth>=1.25.0,<3.0.0dev", # Work around pip wack.
87-
"google-cloud-bigquery>=2.25.2,<3.0.0dev",
87+
"google-cloud-bigquery>=2.25.2,<4.0.0dev",
88+
"google-cloud-bigquery-storage>=2.0.0,<3.0.0dev",
89+
"pyarrow>=3.0.0,<7.0dev",
8890
# Temporarily set maximimum sqlalchemy to a known-working version while
8991
# we debug failing compliance tests. See:
9092
# https://github.com/googleapis/python-bigquery-sqlalchemy/issues/386

testing/constraints-3.6.txt

+2
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,6 @@
77
sqlalchemy==1.2.0
88
google-auth==1.25.0
99
google-cloud-bigquery==2.25.2
10+
google-cloud-bigquery-storage==2.0.0
1011
google-api-core==1.31.5
12+
pyarrow==3.0.0

0 commit comments

Comments
 (0)