Skip to content

Commit ec36a12

Browse files
author
Jim Fulton
authored
fix: supports_multivalues_insert dialect option was mispelled (#278)
1 parent 691cea9 commit ec36a12

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

sqlalchemy_bigquery/base.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,7 @@ class BigQueryDialect(DefaultDialect):
643643
supports_pk_autoincrement = False
644644
supports_default_values = False
645645
supports_empty_insert = False
646-
supports_multiline_insert = True
646+
supports_multivalues_insert = True
647647
supports_unicode_statements = True
648648
supports_unicode_binds = True
649649
supports_native_decimal = True

tests/unit/test_sqlalchemy_bigquery.py

+13
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313
import pytest
1414
import sqlalchemy
1515

16+
from conftest import setup_table
17+
1618

1719
@pytest.fixture
1820
def mock_bigquery_client():
@@ -158,3 +160,14 @@ def test__remove_type_from_empty_in(inp, outp):
158160

159161
r = BigQueryExecutionContext._BigQueryExecutionContext__remove_type_from_empty_in
160162
assert r(None, inp) == outp
163+
164+
165+
def test_multi_value_insert(faux_conn, last_query):
166+
table = setup_table(faux_conn, "t", sqlalchemy.Column("id", sqlalchemy.Integer))
167+
faux_conn.execute(table.insert().values([dict(id=i) for i in range(3)]))
168+
169+
last_query(
170+
"INSERT INTO `t` (`id`) VALUES"
171+
" (%(id_m0:INT64)s), (%(id_m1:INT64)s), (%(id_m2:INT64)s)",
172+
{"id_m0": 0, "id_m1": 1, "id_m2": 2},
173+
)

0 commit comments

Comments
 (0)