fix: show logs when TFX pipelines are submitted #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha-gitg
requested changes
Jan 25, 2022
| @@ -273,6 +274,10 @@ def submit( | |||
| if network: | |||
| self._gca_resource.network = network | |||
|
|
|||
| # Prevents logs from being supressed on TFX pipelines | |||
| if self._gca_resource.pipeline_spec["sdkVersion"].startswith("tfx"): | |||
There was a problem hiding this comment.
Please update the unit tests to include a mock tfx pipeline similar to this:
https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_pipeline_jobs.py#L76
It can then be added to parameterize the current tests here:
https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_pipeline_jobs.py#L240
You may need to update the expected call in the test to add sdkVersion: https://github.com/googleapis/python-aiplatform/blob/main/tests/unit/aiplatform/test_pipeline_jobs.py#L285
sasha-gitg
approved these changes
Jan 26, 2022
ji-yaqi
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where calling
PipelineJob.submit()with TFX pipelines didn't show any logs. This was happening because whentfx.v1is imported, the log level gets set toWARNING. I added a check for TFX pipelines and reset the log level toINFO.Fixes b/209602615.