Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove sync parameter from create_endpoint_sample #695

Merged
merged 6 commits into from
Oct 21, 2021
Merged

fix: Remove sync parameter from create_endpoint_sample #695

merged 6 commits into from
Oct 21, 2021

Conversation

aribray
Copy link
Contributor

@aribray aribray commented Sep 8, 2021

Remove unused sync parameter from create_endpoint_sample

Googlers see 195511018

@aribray
fix: remove unnecessary parameter
f6f3d2c 
Change-Id: I2917bb7a2d428ed179d0034d719ea5a5c0517e5c
@aribray
fix
e3d93ad 
Change-Id: Ie917e1bde719c1897318319d54a72a7be1d9f954
@aribray
fix: remove unnecessary parameter
ce2d590 
Change-Id: I0dd3002e0ac86b14f0d091b92961c264f297616e
@aribray aribray requested review from a team as code owners September 8, 2021 17:23
@aribray aribray requested a review from tmatsuo September 8, 2021 17:23
@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Sep 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2021
@ivanmkc
Copy link
Contributor

ivanmkc commented Sep 20, 2021

You can pass the sync param into the Endpoint.create call. I see other samples are written like that, so might want to follow that to be consistent: https://github.com/googleapis/python-aiplatform/blob/main/samples/model-builder/create_training_pipeline_tabular_classification_sample.py

ivanmkc
ivanmkc approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nicain
nicain approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain nicain added automerge Merge the pull request once unit tests and other checks pass. lang: python Issues specific to Python. type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0477f5a into googleapis:main Oct 21, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

@nicain nicain nicain approved these changes

@tmatsuo tmatsuo Awaiting requested review from tmatsuo

Assignees

@aribray aribray

Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. lang: python Issues specific to Python. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aribray @ivanmkc @nicain