feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples #657

mansiachuthan · 2021-08-25T21:35:10Z

We currently do not support the output of a BigQuery destination uri for the exported evaluated examples from our training step when creating an AutoML Forecast model. Adding this feature would allow users to easily access the evaluated examples and use them for data visualization.

…recasting Training Job in training output

vinnysenthil

Thanks Mansi! Added one comment. Could you also run nox -s lint in the repo root? Looks like you need to run black on training_jobs.py

vinnysenthil · 2021-08-25T21:49:23Z

google/cloud/aiplatform/training_jobs.py

+        try:
+            meta = getattr((self._gca_resource), "training_task_metadata")
+        except ValueError:
+            raise ValueError("BigQuery uri for evaluated data items does not exist. Must export evaluated data items during training.")
+


This can be removed as the try/except below already covers the logic.

Removed try/except block.

Removed the unnecessary try/except block from the evaluated bigquery uri property method in Automl Forecasting

mansiachuthan · 2021-08-31T23:47:57Z

nox -s lint has been successfully run in root of repo

sasha-gitg

Please update the unit tests.

sasha-gitg · 2021-09-08T15:56:12Z

google/cloud/aiplatform/training_jobs.py

@@ -4138,6 +4146,20 @@ def _model_upload_fail_string(self) -> str:
            "Model."
        )

+    @property
+    def evaluated_data_items_bigquery_uri(self) -> Optional[str]:


What are the scenarios where this method:

returns str

returns None

raises ValueError

Updated the method doc string.

google/cloud/aiplatform/training_jobs.py

sasha-gitg · 2021-09-08T16:00:17Z

google/cloud/aiplatform/training_jobs.py

+        try:
+            metadata = self._gca_resource.training_task_metadata
+            return metadata["evaluatedDataItemsBigqueryUri"]
+        except (AttributeError, KeyError):


Why both AttributeError and KeyError?

sasha-gitg · 2021-09-08T16:00:25Z

google/cloud/aiplatform/training_jobs.py

@@ -4138,6 +4146,20 @@ def _model_upload_fail_string(self) -> str:
            "Model."
        )

+    @property
+    def evaluated_data_items_bigquery_uri(self) -> Optional[str]:
+        """BigQuery location of exported evaluated examples from the Training Job"""


Raises section.

No longer needed.

ivanmkc · 2021-09-20T16:54:24Z

@mansiachuthan Any updates on this?

mansiachuthan · 2021-09-20T21:46:15Z

Hello @ivanmkc @sasha-gitg! I just wanted to let you know that my internship ended a few weeks ago and I am currently not working on this PR. I would like to request my mentor @thehardikv to answer any future comments/questions for this pull request, as I would love to see that these changes get merged. Thank you!

google-cla · 2021-09-23T01:30:16Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

ghost · 2021-09-23T17:43:59Z

@googlebot I signed it!

google-cla · 2021-09-23T17:44:15Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

googlebot · 2021-09-28T20:41:21Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

sasha-gitg

One requested change. @thehardikv It seems like this PR may need to closed and opened as a new PR as the CLA bot may be complaining about
mansiachuthan.

sasha-gitg · 2021-10-04T20:30:53Z

google/cloud/aiplatform/training_jobs.py

+        self._assert_gca_resource_is_available()
+
+        metadata = self._gca_resource.training_task_metadata
+        if "evaluatedDataItemsBigqueryUri" in metadata:


Safer to do this: if metadata and "evaluatedDataItemsBigqueryUri" in metadata:

See this issue b/192601601. training_task_metadata may not be populated by the service.

ghost · 2021-10-04T22:40:51Z

@sasha-gitg Before I jump to copying over your changes to a fresh PR (and eliminating the commit history and credit attribution), we're going to try vinnysenthil@'s suggestion: mansiachuthan@ is going to update all the commits to use a personal gmail account (doing something like this: https://stackoverflow.com/a/750182) and to sign the individual Google CLA with that email address here: https://cla.developers.google.com/clas. It's currently using the default no-reply email. Looks like go/github used to associate the @google.com email to mansiachuthan@'s github username, but no longer does.

…atform

google-cla · 2021-10-12T00:52:35Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-12T19:37:07Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-12T21:21:11Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

google-cla · 2021-10-14T06:28:25Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Mansi Achuthan and others added 10 commits August 16, 2021 17:30

Added BigQuery location of exported evaluated examples from AutoML Fo…

66b565d

…recasting Training Job in training output

Testing BQ uri output feature for AutoML Forecasting

b899511

Testing BQ uri output feature for AutoML Forecasting

c225ac7

Testing BQ uri output feature for AutoML Forecasting

29e32bf

Testing BQ uri output feature for AutoML Forecasting

4dfb8b9

Testing BQ uri output feature for AutoML Forecasting

bf869b6

Testing BQ uri output feature for AutoML Forecasting

fca235b

Testing BQ uri output feature for AutoML Forecasting

e519e64

Merge branch 'googleapis:master' into master

73bd6b1

Adding changes from dev to master branch

ef03a20

product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Aug 25, 2021

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 25, 2021

Merge branch 'master' into master

c236824

mansiachuthan marked this pull request as ready for review August 25, 2021 22:53

mansiachuthan changed the title ~~feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples~~ feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples [NOT READY TO MERGE] Aug 25, 2021

vinnysenthil added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 26, 2021

mansiachuthan changed the title ~~feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples [NOT READY TO MERGE]~~ feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples Aug 30, 2021

vinnysenthil removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 30, 2021

vinnysenthil approved these changes Aug 30, 2021

View reviewed changes

Merge branch 'main' into master

9af9db9

vinnysenthil requested a review from sasha-gitg August 30, 2021 23:14

mansiachuthan and others added 2 commits August 30, 2021 16:53

Removed extra try/except block

31d0622

Removed the unnecessary try/except block from the evaluated bigquery uri property method in Automl Forecasting

Fix lint errors

a8c10bb

sasha-gitg requested changes Sep 8, 2021

View reviewed changes

nicain assigned mansiachuthan Sep 20, 2021

Address comments

dd30216

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 23, 2021

Merge branch 'main' into master

1e11c5c

sasha-gitg approved these changes Oct 4, 2021

View reviewed changes

hardik-vala and others added 3 commits October 4, 2021 15:42

Add metadata existence check

b1c3e79

Merge branch 'master' of https://github.com/mansiachuthan/python-aipl…

5583190

…atform

Merge branch 'main' into master

66d3b62

google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 12, 2021

Merge branch 'main' into master

3d78777

Merge branch 'main' into master

fed80c6

Merge branch 'main' into master

cbf044d

vinnysenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021

ghost merged commit c1c2326 into googleapis:main Oct 14, 2021

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples #657

feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples #657

mansiachuthan commented Aug 25, 2021

vinnysenthil left a comment

vinnysenthil Aug 25, 2021

mansiachuthan Aug 31, 2021

mansiachuthan commented Aug 31, 2021

sasha-gitg left a comment

sasha-gitg Sep 8, 2021

ghost Sep 23, 2021

sasha-gitg Sep 8, 2021

ghost Sep 23, 2021

sasha-gitg Sep 8, 2021

ghost Sep 23, 2021

ivanmkc commented Sep 20, 2021

mansiachuthan commented Sep 20, 2021

google-cla bot commented Sep 23, 2021

ghost commented Sep 23, 2021

google-cla bot commented Sep 23, 2021

googlebot commented Sep 28, 2021

sasha-gitg left a comment

sasha-gitg Oct 4, 2021

ghost Oct 4, 2021

ghost commented Oct 4, 2021

google-cla bot commented Oct 12, 2021

google-cla bot commented Oct 12, 2021

google-cla bot commented Oct 12, 2021

google-cla bot commented Oct 14, 2021

feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples #657

feat: enabling AutoML Forecasting training response to include BigQuery location of exported evaluated examples #657

Conversation

mansiachuthan commented Aug 25, 2021

vinnysenthil left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mansiachuthan commented Aug 31, 2021

sasha-gitg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivanmkc commented Sep 20, 2021

mansiachuthan commented Sep 20, 2021

google-cla bot commented Sep 23, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

ghost commented Sep 23, 2021

google-cla bot commented Sep 23, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

googlebot commented Sep 28, 2021

What to do if you already signed the CLA

Individual signers

Corporate signers

sasha-gitg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Oct 4, 2021

google-cla bot commented Oct 12, 2021

google-cla bot commented Oct 12, 2021

google-cla bot commented Oct 12, 2021

google-cla bot commented Oct 14, 2021