-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add filter and timestamp splits #627
feat: add filter and timestamp splits #627
Conversation
b7eac85
to
91d9c20
Compare
training_fraction_split: float = 0.8, | ||
validation_fraction_split: float = 0.1, | ||
test_fraction_split: float = 0.1, | ||
training_fraction_split: Optional[float] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved default setting responsibility to server-side instead of in multiple places in the client.
6558de2
to
07b8843
Compare
training_fraction_split=0.8, | ||
validation_fraction_split=0.1, | ||
test_fraction_split=0.1, | ||
training_fraction_split=None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to None, hence deferring to server.
9b512fd
to
4032b82
Compare
705e976
to
114560f
Compare
@@ -5091,13 +5672,22 @@ def _run( | |||
model_tbt.display_name = model_display_name or self._display_name | |||
model_tbt.labels = model_labels or self._labels | |||
|
|||
# AutoMLVideo does not support validation, so pass in '-' if any other filter split is provided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird thing we have to do for AutoMLVideo, pending discussion with Video team.
@@ -261,18 +258,11 @@ def test_run_call_pipeline_service_create( | |||
if not sync: | |||
model_from_job.wait() | |||
|
|||
true_fraction_split = gca_training_pipeline.FractionSplit( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed since we test splits separately later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ivan! LGTM and left a few comments.
of data will be used for training, 10% for validation, and 10% for test. | ||
|
||
Data filter splits: | ||
Assigns input data to training, validation, and test sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigns input data to training, validation, and test sets | |
If using filter splits all of ``training_filter_split``, ``validation_filter_split`` and | |
``test_filter_split`` must be provided. | |
Assigns input data to training, validation, and test sets |
Please apply this to class docstrings that support filter splits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Supported only for tabular Datasets. | ||
|
||
Timestamp splits: | ||
Assigns input data to training, validation, and test sets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assigns input data to training, validation, and test sets | |
If using timestamp split please provide ```timestamp_split_column_name``` | |
Any of ``training_fraction_split``, ``validation_fraction_split`` and | |
``test_fraction_split`` may optionally be provided. | |
Assigns input data to training, validation, and test sets. |
Please apply this to class docstrings that support timestamp splits.
95b4229
to
c07d7fa
Compare
Will lint and merge. |
Merged without passing 'Sample Lint' check as I didn't modify sample code. |
Changes to training splits:
Future:
Continued from: #549