Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use resource name location when passed full resource name #421

Merged
merged 3 commits into from
May 21, 2021
Merged

fix: use resource name location when passed full resource name #421

merged 3 commits into from
May 21, 2021

Conversation

sasha-gitg
Copy link
Member

No description provided.

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label May 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2021
vinnysenthil
vinnysenthil approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@vinnysenthil vinnysenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question.

tests/unit/aiplatform/test_datasets.py Outdated Show resolved Hide resolved
@sasha-gitg sasha-gitg merged commit f40f322 into googleapis:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnysenthil vinnysenthil vinnysenthil approved these changes

@morgandu morgandu Awaiting requested review from morgandu

@ivanmkc ivanmkc Awaiting requested review from ivanmkc

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasha-gitg @vinnysenthil