Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aiplatform): Fix doc formatting #359

Merged
merged 5 commits into from
May 3, 2021
Merged

fix(aiplatform): Fix doc formatting #359

merged 5 commits into from
May 3, 2021

Conversation

SinaChavoshi
Copy link
Contributor

Fixing docstring formatting for aiplatform.(Fixes #358)

@SinaChavoshi SinaChavoshi requested a review from a team as a code owner April 30, 2021 15:44
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 30, 2021
@SinaChavoshi SinaChavoshi changed the title Fix doc formatting fix(aiplatform): Fix doc formatting Apr 30, 2021
sasha-gitg
sasha-gitg requested changes Apr 30, 2021
View reviewed changes
google/cloud/aiplatform/helpers/value_converter.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/utils.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/utils.py Outdated Show resolved Hide resolved
SinaChavoshi
SinaChavoshi commented Apr 30, 2021
View reviewed changes
Copy link
Contributor Author

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review feedback. Updated accordingly.

google/cloud/aiplatform/utils.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/utils.py Outdated Show resolved Hide resolved
sasha-gitg
sasha-gitg approved these changes Apr 30, 2021
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sina!

@sasha-gitg sasha-gitg merged commit 857f63d into googleapis:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docstring for a few of the methods are not parsable
2 participants
@SinaChavoshi @sasha-gitg