Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add export model #353

Merged
merged 9 commits into from
May 3, 2021
Merged

feat: Add export model #353

merged 9 commits into from
May 3, 2021

Conversation

vinnysenthil
Copy link
Contributor

Summary of Changes

  • Add Model.export_model()
  • Transform and expose Model.supported_export_formats
  • Override __getattr__ in AiPlatformResourceNoun to fall back on the _gca_resource if a particular attribute has not been exposed by the SDK
  • Add 5 unit tests to test export_model()

Fixes b/186130284 🦕

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Apr 26, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2021
sasha-gitg
sasha-gitg requested changes Apr 27, 2021
View reviewed changes
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/base.py Outdated Show resolved Hide resolved
tests/unit/aiplatform/test_models.py Show resolved Hide resolved
@vinnysenthil vinnysenthil mentioned this pull request Apr 27, 2021
Merged
1 task
@vinnysenthil vinnysenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2021
sasha-gitg
sasha-gitg requested changes Apr 28, 2021
View reviewed changes
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Show resolved Hide resolved
tests/unit/aiplatform/test_models.py Show resolved Hide resolved
sasha-gitg
sasha-gitg requested changes Apr 30, 2021
View reviewed changes
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/models.py Show resolved Hide resolved
@sasha-gitg sasha-gitg merged commit 12c5be4 into master May 3, 2021
@sasha-gitg sasha-gitg deleted the export-model branch May 3, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinnysenthil @sasha-gitg @yoshi-kokoro