Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample and reworked create_training_pipeline_custom_job_sample #351

Merged
merged 9 commits into from
May 5, 2021
Merged

feat: Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample and reworked create_training_pipeline_custom_job_sample #351

merged 9 commits into from
May 5, 2021

Conversation

ivanmkc
Copy link
Contributor

@ivanmkc ivanmkc commented Apr 23, 2021 •
edited
Loading

Waiting for #343 to merge.
Added 2 samples.

  • Replaced samples/model-builder/create_training_pipeline_custom_training_managed_dataset_sample.py by incorporating managed dataset logic into other samples.

@ivanmkc ivanmkc requested review from dizcology and a team as code owners April 23, 2021 20:37
@ivanmkc ivanmkc requested review from leahecole and removed request for a team April 23, 2021 20:37
@product-auto-label product-auto-label bot added api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples. labels Apr 23, 2021
@snippet-bot
Copy link

snippet-bot bot commented Apr 23, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@ivanmkc ivanmkc changed the title Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample [WIP] Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample Apr 23, 2021
@ivanmkc ivanmkc changed the title [WIP] Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample feat: [WIP] Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample Apr 26, 2021
@ivanmkc ivanmkc force-pushed the imkc--mbsdk-additional-create-training-pipeline branch from f203673 to 12db685 Compare May 3, 2021 21:01
@ivanmkc ivanmkc requested a review from a team as a code owner May 3, 2021 21:01
@ivanmkc ivanmkc changed the title feat: [WIP] Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample feat: Added create_training_pipeline_custom_package_job_sample and create_training_pipeline_custom_container_job_sample and reworked create_training_pipeline_custom_job_sample May 3, 2021
@ivanmkc ivanmkc requested review from vinnysenthil and sasha-gitg May 3, 2021 21:37
@vinnysenthil vinnysenthil removed the request for review from leahecole May 3, 2021 22:00
vinnysenthil
vinnysenthil suggested changes May 3, 2021
View reviewed changes
samples/model-builder/test_constants.py Outdated Show resolved Hide resolved
samples/model-builder/conftest.py Outdated Show resolved Hide resolved
vinnysenthil
vinnysenthil approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@vinnysenthil vinnysenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please hold merge for Sasha's review on MBSDK usage

@ivanmkc ivanmkc force-pushed the imkc--mbsdk-additional-create-training-pipeline branch from 8b5a3f4 to ac1a911 Compare May 4, 2021 21:58
@ivanmkc ivanmkc merged commit 7abf8ef into googleapis:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@vinnysenthil vinnysenthil vinnysenthil approved these changes

@dizcology dizcology Awaiting requested review from dizcology

Assignees
No one assigned
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanmkc @vinnysenthil @sasha-gitg