Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make aiplatform.Dataset private #296

Merged
merged 8 commits into from
Apr 11, 2021
Merged

feat: Make aiplatform.Dataset private #296

merged 8 commits into from
Apr 11, 2021

Conversation

vinnysenthil
Copy link
Contributor

@vinnysenthil vinnysenthil commented Apr 7, 2021 •
edited by sasha-gitg
Loading

  • Removes all use of aiplatform.Dataset
    • Replaces internal references with aiplatform._Dataset
    • Replaces public references with specific dataset sub-class or TypeVar datasets.SupportedDatasets

TODO after merging

Fixes b/184156060 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2021
@vinnysenthil vinnysenthil marked this pull request as ready for review April 7, 2021 21:30
@vinnysenthil vinnysenthil requested review from a team as code owners April 7, 2021 21:30
@vinnysenthil vinnysenthil added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 7, 2021
sasha-gitg
sasha-gitg requested changes Apr 8, 2021
View reviewed changes
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
google/cloud/aiplatform/training_jobs.py Outdated Show resolved Hide resolved
sasha-gitg
sasha-gitg approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@sasha-gitg sasha-gitg removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 9, 2021
@sasha-gitg sasha-gitg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 11, 2021
@vinnysenthil vinnysenthil added the automerge Merge the pull request once unit tests and other checks pass. label Apr 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 1f0d5f3 into dev Apr 11, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the mb-ds-private branch April 11, 2021 20:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@morgandu morgandu morgandu approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vinnysenthil @busunkim96 @morgandu @sasha-gitg @yoshi-kokoro