Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(samples): improve docstring of Vertex AI Python SDK Model Registry samples #1705

Merged
merged 5 commits into from
Oct 4, 2022
Merged

docs(samples): improve docstring of Vertex AI Python SDK Model Registry samples #1705

merged 5 commits into from
Oct 4, 2022

Conversation

inardini
Copy link
Contributor

@inardini inardini commented Sep 29, 2022 •
edited by vchudnov-g
Loading

Thank you for opening a Pull Request!

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

I open this PR to improve docstring of Vertex AI Python SDK Model Registry samples.

Release-As: 1.18.2

@inardini inardini requested review from a team as code owners September 29, 2022 15:58
@inardini inardini requested a review from nicain September 29, 2022 15:58
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. labels Sep 29, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 30, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 30, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 30, 2022
@nayaknishant nayaknishant added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 30, 2022
@sararob sararob removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 4, 2022
@sararob sararob added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 4, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 4, 2022
@sararob sararob merged commit f97e90f into googleapis:main Oct 4, 2022
@release-please release-please bot mentioned this pull request Oct 4, 2022
Merged
sararob pushed a commit to sararob/python-aiplatform that referenced this pull request Oct 7, 2022
@inardini @andrewferlitsch @sararob
docs(samples): improve docstring of Vertex AI Python SDK Model Regist…
5a9117a 
…ry samples (googleapis#1705)

* improve doc string

* nox tests passed

* rename location

Co-authored-by: Andrew Ferlitsch <[email protected]>
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewferlitsch andrewferlitsch andrewferlitsch approved these changes

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@inardini @andrewferlitsch @sararob @parthea @nayaknishant @yoshi-kokoro