-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update the samples of hyperparameter tuning in the public doc #1600
Conversation
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
hpt_job = aiplatform.HyperparameterTuningJob( | ||
display_name=display_name, | ||
custom_job=custom_job, | ||
metric_spec={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We usually pass in some of these as parameters to the function but I'm not sure how to include things like parameter specs without cluttering the parameter space with all possible parameters to CustomJob and HyperparameterTuningJob.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dizcology do you have guidance or is this okay?
}, | ||
"replica_count": 1, | ||
"container_spec": { | ||
"image_uri": container_uri, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems weird to pass in container_uri
when it's not used in the tuning job.
@dizcology thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hptuning job creates sub jobs(trials) using the container image uri, it's actually used by the vertex hptuning jobs.
In the future, please have one PR per sample. |
}, | ||
"replica_count": 1, | ||
"container_spec": { | ||
"image_uri": container_uri, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hptuning job creates sub jobs(trials) using the container image uri, it's actually used by the vertex hptuning jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in for now.
We can modify the parameters later if required.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #240582178 🦕