Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support custom containers in CustomJob.from_local_script #1483

Merged
merged 9 commits into from
Jul 23, 2022
Merged

feat: Support custom containers in CustomJob.from_local_script #1483

merged 9 commits into from
Jul 23, 2022

Conversation

jaycee-li
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@jaycee-li jaycee-li requested a review from sasha-gitg July 8, 2022 20:00
@jaycee-li jaycee-li self-assigned this Jul 8, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Jul 8, 2022
sasha-gitg
sasha-gitg previously requested changes Jul 11, 2022
View reviewed changes
google/cloud/aiplatform/jobs.py Show resolved Hide resolved
google/cloud/aiplatform/jobs.py Show resolved Hide resolved
tests/unit/aiplatform/test_custom_job.py Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 11, 2022
@sararob sararob added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 15, 2022
@jaycee-li jaycee-li requested a review from a team as a code owner July 22, 2022 21:39
@jaycee-li jaycee-li merged commit be0b7e1 into googleapis:main Jul 23, 2022
@jaycee-li jaycee-li deleted the CustomJob-custom-containers branch July 23, 2022 01:38
@release-please release-please bot mentioned this pull request Jul 23, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SinaChavoshi SinaChavoshi SinaChavoshi approved these changes

@sararob sararob sararob approved these changes

@sasha-gitg sasha-gitg sasha-gitg left review comments

Assignees

@jaycee-li jaycee-li

Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaycee-li @sararob @SinaChavoshi @sasha-gitg